Fix error handling of TxIndex.Search #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4095 +/- ##
=========================================
+ Coverage 66.98% 67% +0.02%
=========================================
Files 247 247
Lines 20993 20993
=========================================
+ Hits 14062 14067 +5
+ Misses 5886 5883 -3
+ Partials 1045 1043 -2
|
melekes
reviewed
Nov 3, 2019
state/txindex/kv/kv.go
Outdated
| @@ -180,9 +180,9 @@ func (txi *TxIndex) Search(q *query.Query) ([]*types.TxResult, error) { | |||
| } else if ok { | |||
| res, err := txi.Get(hash) | |||
| if res == nil { | |||
There was a problem hiding this comment.
what do you think about using a switch here?
switch {
case err != nil:
return []*types.TxResult{}, errors.Wrapf(err, "can't get tx %X", hash)
case res == nil:
return []*types.TxResult{}, nil
default:
return []*types.TxResult{res}, nilThere was a problem hiding this comment.
Good comment :) I think it's nice to have explicit error handling for each state.
I'll change to use the switch statement.
melekes
approved these changes
Nov 4, 2019
|
Could you add an entry to CHANGELOG_PENDING.md? |
This was referenced Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error handling for performing a txindex search.
TxIndex.Getreturns(txresult, nil)if the transaction is found.(nil, nil)if the transaction is not found.(nil, error)if error is occurred.Therefore, if
resis notnil, I thinkTxIndex.Searchshould return(txresult, nil).Previously, however, this was not a problem because
errors.Wrapreturnsnilif its first argumenterrisnil.