Skip to content

tendermint node: show useful error when tendermint has not been initialised #4303

Closed
@melekes

Description

@melekes

#4286

TMHOME="/Users/daniel/go/src/github.com/tendermint/thome" tendermint node --proxy_app=unix:///Users/daniel/go/src/github.com/kvstore/example.sock

ERROR: 1 error(s) decoding:

* error decoding 'consensus.create_empty_blocks_interval': time: invalid duration 

We should output more useful error instead of ^ for better usability.

Activity

changed the title tendermint node: useful error when tendermint has not been initialised tendermint node: show useful error when tendermint has not been initialised on Jan 13, 2020
SomeMoosery

SomeMoosery commented on Jan 16, 2020

@SomeMoosery

This would be my first issue but I can take a look into this and see if I can come up with a PR shortly!

SomeMoosery

SomeMoosery commented on Jan 16, 2020

@SomeMoosery

#4312 - PR here!

self-assigned this
on Mar 2, 2020
melekes

melekes commented on Mar 2, 2020

@melekes
ContributorAuthor

Question: should we initialize Tendermint instead of showing an error?

pros:

  • users don't have to call tendermint init

cons:

  • potential errors due to misconfiguration (e.g. configuration exists in DIR1, but TM_HOME=DIR2 was used in command line => new configuration created)
erikgrinaker

erikgrinaker commented on Mar 2, 2020

@erikgrinaker
Contributor

I think we should throw a hard error. Explicit is better than implicit, and this is something that would be done rarely.

added a commit that references this issue on Mar 2, 2020
80cc777

1 remaining item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    tendermint node: show useful error when tendermint has not been initialised · Issue #4303 · tendermint/tendermint