Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/common: Refactor libs/common 5 #4240

Merged
merged 8 commits into from
Dec 12, 2019
Merged

libs/common: Refactor libs/common 5 #4240

merged 8 commits into from
Dec 12, 2019

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Dec 11, 2019 •
edited
Loading

  • move mathematical functions and types out of libs/common to math pkg
  • move net functions out of libs/common to net pkg
  • move string functions out of libs/common to strings pkg
  • move async functions out of libs/common to async pkg
  • move bit functions out of libs/common to bits pkg
  • move cmap functions out of libs/common to cmap pkg
  • move os functions out of libs/common to os pkg

closes #4147
Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle
libs/common: Refactor libs/common 5
d6cc0f0 
- move mathematical functions and types out of `libs/common` to math pkg
- move net functions out of `libs/common` to net pkg
- move string functions out of `libs/common` to strings pkg
- move async functions out of `libs/common` to async pkg
- move bit functions out of `libs/common` to bits pkg
- move cmap functions out of `libs/common` to cmap pkg
- move os functions out of `libs/common` to os pkg

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added C:libs Component: Library T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Dec 11, 2019
@tac0turtle tac0turtle self-assigned this Dec 11, 2019
@tac0turtle
fix testing issues
f7f5af6
@tac0turtle
Merge branch 'master' into marko/refactor_libs-common_5
853fff1
@tac0turtle
fix tests
30c981b 
closes #41417

woooooooooooooooooo kill the cmn pkg

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
golangcibot
golangcibot reviewed Dec 11, 2019
View reviewed changes
@tac0turtle tac0turtle marked this pull request as ready for review December 11, 2019 22:34
golangcibot
golangcibot reviewed Dec 11, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #4240 into master will decrease coverage by 0.26%.
The diff coverage is 60.82%.

@@            Coverage Diff             @@
##           master    #4240      +/-   ##
==========================================
- Coverage   67.15%   66.88%   -0.27%     
==========================================
  Files         247      225      -22     
  Lines       21540    19327    -2213     
==========================================
- Hits        14465    12927    -1538     
+ Misses       5999     5423     -576     
+ Partials     1076      977      -99
Impacted Files Coverage Δ
libs/strings/string.go 81.57% <ø> (ø)
libs/async/async.go 89.55% <ø> (ø)
libs/cmap/cmap.go 90.9% <ø> (ø)
libs/net/net.go 31.57% <ø> (ø)
rpc/core/consensus.go 0% <0%> (ø) ⬆️
rpc/core/tx.go 0% <0%> (ø) ⬆️
cmd/tendermint/commands/reset_priv_validator.go 5.88% <0%> (ø) ⬆️
consensus/state.go 77.47% <0%> (-0.43%) ⬇️
cmd/tendermint/commands/gen_node_key.go 0% <0%> (ø) ⬆️
consensus/replay_file.go 0% <0%> (ø) ⬆️
... and 82 more

@tac0turtle tac0turtle merged commit 7b52f51 into master Dec 12, 2019
@tac0turtle tac0turtle deleted the marko/refactor_libs-common_5 branch December 12, 2019 08:33
@evsmithx evsmithx mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot

@melekes melekes

@ebuchman ebuchman

@tessr tessr

Assignees

@tac0turtle tac0turtle

Labels
C:libs Component: Library T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor libs/common package
4 participants
@tac0turtle @codecov-io @melekes @golangcibot