Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/common: refactor libs common 3 #4232

Merged
merged 4 commits into from
Dec 11, 2019
Merged

libs/common: refactor libs common 3 #4232

merged 4 commits into from
Dec 11, 2019
+163 −150

Conversation

tac0turtle
Copy link
Contributor

  • move nil.go into types folder and make private
  • move service & baseservice out of common into service pkg

ref #4147

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Sorry, something went wrong.

@tac0turtle
libs/common: refactor libs common 3
0f3c35c 
- move nil.go into types folder and make private
- move service & baseservice out of common into service pkg

ref #4147

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added C:libs Component: Library T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Dec 10, 2019
@tac0turtle tac0turtle self-assigned this Dec 10, 2019
@tac0turtle tac0turtle marked this pull request as ready for review December 10, 2019 14:57
@codecov-io
Copy link

codecov-io commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #4232 into master will increase coverage by 0.27%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master   #4232      +/-   ##
=========================================
+ Coverage   66.83%   67.1%   +0.27%     
=========================================
  Files         246     222      -24     
  Lines       21281   19115    -2166     
=========================================
- Hits        14223   12827    -1396     
+ Misses       5993    5323     -670     
+ Partials     1065     965     -100
Impacted Files Coverage Δ
blockchain/v1/reactor.go 81.49% <ø> (ø) ⬆️
libs/service/service.go 54.54% <ø> (ø)
privval/signer_endpoint.go 81.08% <ø> (+5.4%) ⬆️
rpc/client/mock/client.go 16% <ø> (ø)
blockchain/v0/reactor.go 78.77% <ø> (+0.94%) ⬆️
lite2/rpc/client.go 0% <0%> (ø) ⬆️
p2p/pex/pex_reactor.go 82.48% <0%> (ø) ⬆️
p2p/peer.go 60.89% <100%> (ø) ⬆️
p2p/trust/metric.go 80.23% <100%> (ø) ⬆️
libs/pubsub/pubsub.go 85.96% <100%> (ø) ⬆️
... and 63 more

@tac0turtle tac0turtle merged commit 27b00cf into master Dec 11, 2019
@tac0turtle tac0turtle deleted the marko/refactor_libs-common_3 branch December 11, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes

@ebuchman ebuchman

@tessr tessr

Assignees

@tac0turtle tac0turtle

Labels
C:libs Component: Library T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tac0turtle @codecov-io @melekes