Skip to content

The “genesis_time” field is ignored #2294

Closed
@KrzysiekJ

Description

@KrzysiekJ

When the genesis_time field in the genesis.json file contains a future date & time, Tendermint ignores that and starts producing blocks right after launch (if there is quorum). An expected behaviour would be to wait until that date.

Tested on 0.21.0.

Activity

ValarDragon

ValarDragon commented on Aug 29, 2018

@ValarDragon
Contributor

Could you double check if this problem persists on v0.23.0? We've made a couple changes to time, so that may have fixed this problem.

KrzysiekJ

KrzysiekJ commented on Aug 29, 2018

@KrzysiekJ
ContributorAuthor

Yes, it persists.

milosevic

milosevic commented on Aug 29, 2018

@milosevic
Contributor

It should normally be fixed in #2203.

added this to the launch milestone on Aug 31, 2018
ebuchman

ebuchman commented on Aug 31, 2018

@ebuchman
Contributor

Don't think this is actually fixed in #2203.

Also not 100% on how we should do this - can we somehow just not start the ConsensusState until genesis time ?

melekes

melekes commented on Sep 4, 2018

@melekes
Contributor

Also not 100% on how we should do this - can we somehow just not start the ConsensusState until genesis time ?

Can't we just Sleep in node#OnStart somewhere until genesis time is reached?

milosevic

milosevic commented on Sep 4, 2018

@milosevic
Contributor

I was thinking the same.

ebuchman

ebuchman commented on Sep 4, 2018

@ebuchman
Contributor

Can't we just Sleep in node#OnStart somewhere until genesis time is reached?

Yes, though I was thinking we'd start up the other services (eg. pex and mempool) ahead of time.

Certainly a simple solution for now is to just sleep.

milosevic

milosevic commented on Sep 5, 2018

@milosevic
Contributor

Yes, though I was thinking we'd start up the other services (eg. pex and mempool) ahead of time.

This would actually be useful. Lets just check the complexity of doing it. If it's too complex then it might be done postlaunch and we go now with the simple sleep.

melekes

melekes commented on Sep 18, 2018

@melekes
Contributor

Simple solution was implemented by @milosevic and merged to develop.

2 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C:consensusComponent: ConsensusT:bugType Bug (Confirmed)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    The “genesis_time” field is ignored · Issue #2294 · tendermint/tendermint