Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: fix register concrete name. #2213

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

peerlink
Copy link
Contributor

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2213 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
+ Coverage   62.48%   62.71%   +0.22%     
==========================================
  Files         216      216              
  Lines       17296    17313      +17     
==========================================
+ Hits        10807    10857      +50     
+ Misses       5605     5575      -30     
+ Partials      884      881       -3
Impacted Files Coverage Δ
blockchain/reactor.go 39.44% <100%> (ø) ⬆️
types/validator.go 74% <0%> (-4.13%) ⬇️
consensus/state.go 76.44% <0%> (-0.99%) ⬇️
types/vote_set.go 45.12% <0%> (-0.06%) ⬇️
p2p/peer.go 57.95% <0%> (ø) ⬆️
libs/common/heap.go 0% <0%> (ø) ⬆️
blockchain/pool.go 66.43% <0%> (+0.69%) ⬆️
consensus/reactor.go 73.02% <0%> (+1.07%) ⬆️
libs/clist/clist.go 69.06% <0%> (+1.65%) ⬆️
config/config.go 83.58% <0%> (+1.77%) ⬆️
... and 1 more

@melekes melekes changed the base branch from master to develop August 13, 2018 11:15
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@melekes melekes merged commit 3624a17 into tendermint:develop Aug 13, 2018
@ebuchman
Copy link
Contributor

:o thanks for catching this

@ValarDragon
Copy link
Contributor

Did this get into a release? If so we probably should add this to breaking changes right?

@ebuchman
Copy link
Contributor

firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---
Closes tendermint#2213 

#### PR checklist

- [X] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [X] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants