Add section in docs about TypeScript #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojpawlik
reviewed
Aug 29, 2020
There was a problem hiding this comment.
Good addition. This should be near the Extending context paragraph tho.
Also, I was recently permitted to introduce breaking changes, so it's a perfect time to try to make it less necessary to extend context by hand. session can be correctly typed as Middleware.ExtFn, and Composer::use can be overloaded to pick it up.
wojpawlik
reviewed
Sep 3, 2020
Co-authored-by: Wojciech Pawlik <woj.pawlik@gmail.com>
wojpawlik
requested changes
Sep 3, 2020
Co-authored-by: Wojciech Pawlik <woj.pawlik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a section to the docs about some caveats when using the project with TypeScript.
Should perhaps only be merged after #1074 because technically there are still some parts in JS.
Fixes #914
Type of change
Please delete options that are not relevant.
Checklist: