I know that formatting-only changes are not welcome. We avoid them using Prettier. However, if someone commits code to the repo that does not follow the formatting conventions, I believe it is better to fix the formatting once and do it properly rather than permitting that people keep on submitting formattings that follow their own rules. That way, we can keep everyone in sync.

I don't personally have something against import type declarations, I understand their purpose. I suggest following the recommendations from the TS team. I quote:

This feature is something most users may never have to think about; however, if you’ve hit issues under --isolatedModules, TypeScript’s transpileModule API, or Babel, this feature might be relevant.

What they're basically saying is that this should only be used when necessary. telegraf applied them inconsistently and without having a reason to do so. I'm completely fine with using them everywhere if that is desired for some reason, however, as they were used only sparingly, I decided that the consistent state of not using them at all is better than the consistent state of using them wherever possible.

Is there anything you can say about the three major points I listed in the description? I'd be happy to see the remaining 37 compilation errors fixed

Well the problem is that these types are also directly exposed to library consumers. telegraf is not fully usable with TS without the types because how would someone work with polls without telegraf providing poll on the Message type? We could only allow arbitrary keys and then live with all the problems that come with it.

I agree on all the other stuff you said but I still don't quite see how we could switch to generated .d.ts files without a full coverage of the Telegram API … IMO do we need to fix that script generating types.

For this PR we most likely have to re-enable allowJs again. This really is a pity because it makes the whole work superfluous for my use-case.
EDIT: I saw you just did

One does not simply fix that script.

I see … I had a look at the repo and didn't feel like doing that either.

What use-case requires the library to be fully typed?

You might have heard of awilix and of its integration with express or koa. I sort of want to recreate awilix-koa for telegraf. In an ideal (~typed) world, I do not have to re-specify the entire list of available Telegram methods. Instead, I would like to stay so generic that updates to telegraf “automatically” become available in awilix-telegraf. I therefore want to do some type transformations on the API surface of telegraf and thus get my library from it. But this is really hard if not all methods are properly typed, including parameters and return types and everything. As my plan includes a quite deep integration with telegraf, I will most likely also benefit from the internals being fully typed.

I know that technically this would all work without TS in the first place, but if it actually ends up being as generic as I'm contemplating, then I don't want to think about all the bugs I introduce when I don't have full type safety.

The main reason behind having awilix-telegraf is that larger bots almost inevitably end up combining a web server with a bot. Sooner or later, you almost certainly want to integrate with other APIs/OAuth/websites/you-name-it. As large web servers in Node.js are preferably using DI in some sort, it would be awesome to have telegraf integrate seamlessly with awilix.

I'm nitpicking at this point. Great work, I'll merge it after 24 hours, in case me, you or @dotcypress spots something wrong. Looking forward to reviewing your subsequent PRs :)

Thanks!

Can I somehow use these typings in my project?

@foodornt sure, check out typegram

@KnorpelSenf thank you man.

btw, is there any wizardscene typings you know of?
or can I somehow use the develop branch to make my bot.

EDIT: I've done npm install https://github.com/telegraf/telegraf.git and I got some pretty good typings.
my neovim lsp got some errors when I tried to view these typings. adding the default tsconfig.ts file to the telegraf directory solved the issue (Execute the command tsc --init in that directory).

I lack a lot of knowledge in regards of relates to typescript, but is it right that I can't use ctx.wizard when adding middlewares to the wizard scene?

If anybody has that issue too, let me know. I checked the wizard scene ts file, and it looked alright. I mean there's an implemented middleware object that's doing something to use the wizard context but for some reason it's not working. is that a bug or am I missing out on something?

Even though I migrated the module, I'm not an expert on wizards, so I cannot really help you here.

Feel free to open an issue and remember to include an SSCCE if possible. People won't necessarily read an old PR that's already been merged some time ago.

@KnorpelSenf I think I worked it out by changing some types .
Much appreciated, thank you for helping!