add telegram.editMessageMedia typing #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before all arguments could be undefined which doesnt work
fix Markup type (correct on context) arguments can be undefined but they should be explicitly This way you state explicitly what you want and dont forget something. This way typescript can actually help you BREAKING CHANGE: you have to supply undefined where you could ommit the argument before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #979
Type of change
Please delete options that are not relevant.
Breaking Change (Typescript users only): you have to explicitly specify undefined when you want to remove the caption or markup on an existing message.
This way typescript knows this is intended and not just a forgotten argument.
Checklist: