handle all terminal states when processing logs #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior check for whether the results Object had completed did not account for objects which had been cancelled. Rather then check every conceivable terminal state, this commit instead makes sure it is not in the Unknown state, which means it has not terminated. rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
|
/assign @avinal @enarha @ramessesii2 @khrm FYI |
sayan-biswas
approved these changes
Feb 1, 2024
tekton-robot
added
the
approved
ramessesii2
approved these changes
Feb 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramessesii2, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v0.9.x |
|
@khrm: new pull request created: #701 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #698
/kind bug
The prior check for whether the results Object had completed did not account for objects which had been cancelled. Rather then check every conceivable terminal state, this commit instead makes sure it is not in the Unknown state, which means it has not terminated.
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes