-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation for all tektoncd repos #3
Comments
Before this change only `community` and `pipeline` had automatic tide merging via Prow. Now all of the existing repos will have it. Partially addresses tektoncd#3 (Also simplified the config, looking at the knative config as an example https://github.com/knative/test-infra/blob/691caf51f2bb9ef86888772a8cc5d7952687b7c6/ci/prow/config.yaml#L51-L65 it looks like we can use the same stanza for multiple repos)
I also had to add branch protection rules to all the repos to make sure the tide check was required. Will need to back and add a requirement about the
|
/assign |
@bobcatfish updated the requirements for For |
A couple ideas:
Another issue is that when code in a dir changes, we probably want to only run the tests for that dir - but we can always deal with this iteratively XD |
Add basic docs as specified at https://github.com/tektoncd/community/blob/master/process.md#project-requirements. Note that a lot of the specifics about contributing and development hinge on us fleshing out support for experimental projects, something partially captured in tektoncd/plumbing#3.
Add basic docs as specified at https://github.com/tektoncd/community/blob/master/process.md#project-requirements. Note that a lot of the specifics about contributing and development hinge on us fleshing out support for experimental projects, something partially captured in tektoncd/plumbing#3.
Add basic docs as specified at https://github.com/tektoncd/community/blob/master/process.md#project-requirements. Note that a lot of the specifics about contributing and development hinge on us fleshing out support for experimental projects, something partially captured in tektoncd/plumbing#3.
#37 is merged 💃 |
@vdemeester: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @vdemeester !!!! ❤️ ❤️ ❤️ |
Part of [tektoncd-catalog#3][tektoncd#3]. This commit adds the `tektoncd-catalog` org to the `orgs` parameter of label syncer so that the `tektoncd-catalog` org can automatically maintain the labels as `tektoncd`. There is no change to the `labels.yaml` file itself. [tektoncd#3]: tektoncd-catalog/.github#3
Part of [tektoncd-catalog#3][#3]. This commit adds the `tektoncd-catalog` org to the `orgs` parameter of label syncer so that the `tektoncd-catalog` org can automatically maintain the labels as `tektoncd`. There is no change to the `labels.yaml` file itself. [#3]: tektoncd-catalog/.github#3
Part of [Verified Catalog Migration][tektoncd#3]. This commit adds a new script containing the common helper script code for [Verified Catalogs][Verified Catalog]. The content is based on: https://github.com/tektoncd/catalog/blob/main/test/e2e-common.sh, with improvements/refactoring for the new catalog git-based versioning and decentralized-repo model contracts. The script supports both on PR merge integration test and nightly integration tests, specified by `TEST_RUN_NIGHTLY_TESTS` env variable. In nightly test, the script runs test cases in all release of the catalog. In on-PR-merge test, the script runs test cases in the branch head. An e2e use example can found in: https://github.com/QuanZhang-William/golang/tree/test-pipelines. [tektoncd#3]: tektoncd-catalog/.github#3 [Verified Catalog]: https://github.com/tektoncd-catalog
Part of [Verified Catalog Migration][tektoncd#3]. This commit adds a new script containing the common helper script code for [Verified Catalogs][Verified Catalog]. The content is based on: https://github.com/tektoncd/catalog/blob/main/test/e2e-common.sh, with improvements/refactoring for the new catalog git-based versioning and decentralized-repo model contracts. The script supports both on PR merge integration test and nightly integration tests, specified by `TEST_RUN_NIGHTLY_TESTS` env variable. In nightly test, the script runs test cases in all release of the catalog. In on-PR-merge test, the script runs test cases in the branch head. An e2e use example can found in: https://github.com/QuanZhang-William/golang/tree/test-pipelines. [tektoncd#3]: tektoncd-catalog/.github#3 [Verified Catalog]: https://github.com/tektoncd-catalog
Part of [Verified Catalog Migration][tektoncd#3]. This commit adds a new script containing the common helper script code for [Verified Catalogs][Verified Catalog]. The content is based on: https://github.com/tektoncd/catalog/blob/main/test/e2e-common.sh, with improvements/refactoring for the new catalog git-based versioning and decentralized-repo model contracts. The script supports both on PR merge integration test and nightly integration tests, specified by `TEST_RUN_NIGHTLY_TESTS` env variable. In nightly test, the script runs test cases in all release of the catalog. In on-PR-merge test, the script runs test cases in the branch head. An e2e use example can found in: https://github.com/QuanZhang-William/golang/tree/test-pipelines. [tektoncd#3]: tektoncd-catalog/.github#3 [Verified Catalog]: https://github.com/tektoncd-catalog
Part of [Verified Catalog Migration][#3]. This commit adds a new script containing the common helper script code for [Verified Catalogs][Verified Catalog]. The content is based on: https://github.com/tektoncd/catalog/blob/main/test/e2e-common.sh, with improvements/refactoring for the new catalog git-based versioning and decentralized-repo model contracts. The script supports both on PR merge integration test and nightly integration tests, specified by `TEST_RUN_NIGHTLY_TESTS` env variable. In nightly test, the script runs test cases in all release of the catalog. In on-PR-merge test, the script runs test cases in the branch head. An e2e use example can found in: https://github.com/QuanZhang-William/golang/tree/test-pipelines. [#3]: tektoncd-catalog/.github#3 [Verified Catalog]: https://github.com/tektoncd-catalog
Expected Behavior
All of the repos in tektoncd should have a minimum of prow automation applied.
We should have tide automation for:
We should add unit test support for:
Unit test support is going to be interesting, the easiest way to add this initially is probably to copy-paste the prow jobs as is and add exactly the script the knative-tests image expects:
plumbing/prow/config.yaml
Lines 107 to 108 in 2ff5265
OR we could be adventurous and try using our own script.
OR be very adventurous and try our own image.
Actual Behavior
Pipelines has all the bells and whistles, the rest of the projects seem to have only a random smattering (e.g. community has tide merging, but this repo doesn't).
Additional Info
unit-test
section from pipelines and duplicate it for the other repos.The text was updated successfully, but these errors were encountered: