-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tekton: update bugfix-release.sh script for ghcr.io #8323
Conversation
@afrittoli ^^ |
1e66fed
to
e660e70
Compare
/kind misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one lit, looks good otherwise
/approve
tekton/bugfix-release.sh
Outdated
--param=imageRegistry=ghcr.io \ | ||
--param=imageRegistryRegions="" \ | ||
--param=imageRegistryPath=tektoncd/pipeline \ | ||
--param=imageRegistryRegions="" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated from L44
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following the update of the cheatsheet, updating the script to pick up the changes. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
e660e70
to
62d2223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Following the update of the cheatsheet, updating the script to pick up
the changes.
/kind misc
/cc @afrittoli
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes