Run CI YAML Example tests using go test
#2685
Conversation
|
|
tekton-robot
added
size/L
|
Hi @thomaschandler. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
2 similar comments
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
thomaschandler
force-pushed
the
ci_yaml_with_go_test
branch
2 times, most recently
from
3b9dfd7 to
eef02f1
Compare
|
The sidecar-test is known for being flaky :( #2656 |
thomaschandler
force-pushed
the
ci_yaml_with_go_test
branch
from
eef02f1 to
51b1f17
Compare
@jlpettersson Thanks for the heads up :) I've been flaky and not pushed all my changes, fingers crossed all is well now! |
|
/cc @bobcatfish |
thomaschandler
force-pushed
the
ci_yaml_with_go_test
branch
from
51b1f17 to
eacb450
Compare
ghost
mentioned this pull request
|
Whoops, sorry @thomaschandler that we both ended up working on this one at the same time :( I think that #2541 which I've been working on is passing tests right now (or did last week crossed fingers) - looking at this one and at #2541 it seems like they are very similar, but this one has some improvements in that it's making use of the test libs vs calling out to kubectl constantly like I'm doing - assuming #2541 continues passing, what do you think if we merge that one and then you could merge the improvements that this PR adds? |
@bobcatfish No worries! Promising to see the overlap so that I know I'm somewhat on the money. I'll rebase once #2541 is merged in. Am I ok to keep this MR open and attached to #1251? Do you have any design suggestions as I integrate with your changes? |
There was a lot more overlap than I expected!! Both PRs had the tests each running in their own namespace and both were making use of the cleanup interrupt handler :D
I think the biggest difference is that you were using our existing libs to poll instead of recreating the logic and shelling out to kubectl like I am, which is a big improvement! :D So no particular feedback from me - sorry again about this! |
thomaschandler
force-pushed
the
ci_yaml_with_go_test
branch
from
eacb450 to
a1f6bb0
Compare
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
/kind misc |
thomaschandler
force-pushed
the
ci_yaml_with_go_test
branch
from
39a0c85 to
820f8fe
Compare
tekton-robot
added
size/L
There was a problem hiding this comment.
This is great, looks really clean!! Thanks @thomaschandler (and sorry it took so long to get back to this)
I'm very very excited to have this!
/lgtm
/approve
/meow
| @@ -17,7 +17,7 @@ spec: | |||
| tasks: | |||
| - name: cluster-task-pipeline-4 | |||
| taskRef: | |||
| name: cluster-task-pipeline-4 | |||
| name: cluster-task-pipeline-4-v1alpha1 | |||
| failed=1 | ||
| fi | ||
| done | ||
| go_test_e2e -tags=examples -timeout=20m ./test/ || failed=1 |
There was a problem hiding this comment.
good catch, i didnt notice this script!
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. part of: tektoncd#5193
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates resources in v1 examples that are not under beta or no-ci. part of: tektoncd#5193
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates resources in v1 examples that are not under beta or no-ci. part of: tektoncd#5193
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates resources in v1 examples that are not under beta or no-ci. part of: tektoncd#5193
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates resources in v1 examples that are not under beta or no-ci. part of: tektoncd#5193
Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed and removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in tektoncd#1351 and then removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in tektoncd#1351 and then removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in tektoncd#1351 and then removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in tektoncd#1351 and then removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in tektoncd#1351 and then removed in tektoncd#2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes tektoncd#6868
…esources Scenario 2 of the upgrade test aims to install pipeline server from the preivous release, create resources from that version and test on those resources against the client of the current release. This commit restores the resources creation of simple Task and Pipeline resources to enable the 2nd scenario of the upgrade test to work by applying the resources from the old server version of pipeline. It was preivously renamed in #1351 and then removed in #2685. It fixes the missing piece where the required resources from the previous release have not been created to accomplish scenario 2 of the upgrade test. More specifically, it creates a simple Task and Pipeline resources and then runs the two simple resources with a TaskRun and PipelineRun created after upgrading to the current version and verify that they both run successfully. /kind misc Closes #6868
Changes
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes #1251
Add a new
yamlbuild tag so that existing integration tests aren'taffected. Future updates to SubEnv may allow e2e tests to be run entirely
locally by avoiding external deps, see #1372
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
N/A