Add script mode for Conditions #1798
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
size/M
|
Hi @cezkuj. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @dlorenc |
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
The following is the coverage report on pkg/.
|
docs/conditions.md
Outdated
| The container image runs till completion. The container must exit successfully i.e. with an exit code 0 | ||
| for the condition evaluation to be successful. All other exit codes are considered to be a condition check | ||
| failure. | ||
| Similar to `Task` the check also supports [`script` mode](./tasks.md#step-script). The container image runs |
There was a problem hiding this comment.
I think it would make sense to say something along the lines of: "The check must specify a Step (link to Step docs)" as opposed to keeping references to the container image/contract.
| @@ -41,5 +41,13 @@ func (cs *ConditionSpec) Validate(ctx context.Context) *apis.FieldError { | |||
| if cs.Check.Image == "" { | |||
| return apis.ErrMissingField("Check.Image") | |||
| } | |||
| if cs.Check.Script != "" { | |||
There was a problem hiding this comment.
If you are feeling motivated, it might be worth seeing if we can reuse the validateSteps function from task_validation.go here as well: https://github.com/tektoncd/pipeline/blob/master/pkg/apis/pipeline/v1alpha1/task_validation.go#L169
There was a problem hiding this comment.
I reused it "as is", validation error is not ideal, as it mentions steps - up to you if we want it improve it further
tekton-robot
added
the
approved
cezkuj
force-pushed
the
condition-script
branch
from
ae1c5df to
d6a7fad
Compare
Allows to use simplified way of creating shell script, same as for Tasks. Fixes tektoncd#1694
cezkuj
force-pushed
the
condition-script
branch
from
d6a7fad to
c505191
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for adding this support 👍 |
Changes
Allows to use simplified way of creating shell script, same as for Tasks.
Fixes #1694
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes