Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting Comment Typos and Updating cancelPipelineRun Error Message #1780

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Correcting Comment Typos and Updating cancelPipelineRun Error Message #1780

merged 1 commit into from
Dec 20, 2019

Conversation

danielhelfand
Copy link
Member

@danielhelfand danielhelfand commented Dec 19, 2019 •
edited
Loading

This pull request changes the error message for cancelling a pipelinerun's taskruns. There can potentially be multiple errors so the message should reflect that. I also changed the message itself to be a little more easy to interpret.

Also correcting minor typos for comments.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

More descriptive error from cancelling a TaskRun associated with a cancelled PipelineRun

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Dec 19, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2019
vdemeester
vdemeester approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@tekton-robot tekton-robot merged commit 31908ca into tektoncd:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielhelfand @tekton-robot @vdemeester @googlebot