Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass rest config when create tkn clients,fix the default QPS is to low(QPS is 5),can improve the concurrent #1512 #1513

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

tomonight
Copy link
Contributor

pass the k8s config when create log clients , share k8s config.

fix or feature: #1506


pass the k8s config when create log clients , share k8s config,  change the default clients QPS 5

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 25, 2022
@tekton-robot
Copy link
Contributor

Hi @tomonight. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2022
@tomonight
Copy link
Contributor Author

/ok-to-test

@tekton-robot
Copy link
Contributor

@tomonight: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2022
@tomonight
Copy link
Contributor Author

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@tekton-robot tekton-robot merged commit 16cf73b into tektoncd:main Feb 28, 2022
piyush-garg added a commit that referenced this pull request Mar 9, 2022
#1498 | [Pradeep Kumar] update tkn v0.22.0 | 2022/02/01-22:04
#1499 | [Daniel Helfand] update tkn chocolatey package to v0.22.0 | 2022/02/02-10:17
#1503 | [Chmouel Boudjnah] Use ubuntu-rolling to build package | 2022/02/03-10:17
#1505 | [Shubham] Make `vendor` a PHONY target | 2022/02/07-10:50
#1500 | [Chmouel Boudjnah] Add export option for pipelinerun | 2022/02/15-12:01
#1484 | [mansi103] Checked existence of resources before deletion | 2022/02/16-13:46
#1513 | [tomonight] pass rest config when create tkn clients,fix the default QPS is to low(QPS is 5),can improve the concurrent | 2022/02/28-09:14
#1514 | [Piyush Garg] Bump deps of pipeline and triggers | 2022/02/28-13:53
#1509 | [mansi103] Adds chains version in output of tkn version command | 2022/03/01-12:52
#1440 | [Rémy Greinhofer] Add Chains management command | 2022/03/03-15:01
null | [Vincent Demeester] Fix vendoring | 2022/03/03-15:01
null | [Vincent Demeester] Temporary disable linting tarball package | 2022/03/03-15:01
null | [jbpratt] remove unnecessary filepath join | 2022/03/04-08:13
null | [jbpratt] gofmt -w test/e2e/* | 2022/03/04-08:27
null | [jbpratt] replace t.Errorf %w with %v | 2022/03/04-09:17
null | [PuneetPunamiya] Bump Tekton Hub CLI to latest | 2022/03/04-10:37
null | [Pradeep Kumar] fix missing Cursor with interactive start commands | 2022/03/04-12:13
null | [Chmouel Boudjnah] Fix tektoncd docs installation instructions | 2022/03/08-08:08
null | [Piyush Garg] Make chains namespace configurable | 2022/03/09-09:29
null | [Piyush Garg] Bump chains and hub deps | 2022/03/09-09:29

Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants