Adds operator verison in output of `tkn version` command #1486

PuneetPunamiya · 2022-01-21T06:52:04Z

Adds operator verison in output of tkn version command

UI Example

$ tkn version
Client version: 0.21.0
Pipeline version: v0.28.2
Triggers version: v0.16.1
Operator version: v0.53.0

Fixes: #1473

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

tekton-robot · 2022-01-21T06:55:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/version/version.go	73.7%	71.6%	-2.1
pkg/version/version.go	91.4%	89.5%	-2.0

tekton-robot · 2022-01-21T09:11:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vinamra28

overall PR looks good 👍
just a couple of comments and it is good to merge

pkg/version/version.go

vinamra28 · 2022-01-21T14:26:30Z

pkg/cmd/version/version_test.go

+		name:                  "deployment with pipeline, triggers, dashboard and operator installed",
+		namespace:             "test",
+		userProvidedNamespace: "test",
+		deployment:            []*v1.Deployment{pipelineDeployment, triggersDeployment, dashboardDeployment},


how about we provide the configmap for the remaining components as well instead of using deployments?

tekton-robot · 2022-01-24T04:49:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/version/version.go	73.7%	71.6%	-2.1
pkg/version/version.go	91.4%	89.5%	-2.0

Fixes: tektoncd#1473 Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

tekton-robot · 2022-01-24T05:58:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/version/version.go	73.7%	71.6%	-2.1
pkg/version/version.go	91.4%	89.5%	-2.0

vinamra28

PR looks good 👍
/lgtm

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 21, 2022

tekton-robot requested review from piyush-garg and sthaha January 21, 2022 06:52

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2022

vdemeester approved these changes Jan 21, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022

vinamra28 reviewed Jan 21, 2022

View reviewed changes

PuneetPunamiya force-pushed the add-operator-version branch from af9a37c to d7780ec Compare January 24, 2022 04:45

Adds operator verison in output of tkn version command

f123faa

Fixes: tektoncd#1473 Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

PuneetPunamiya force-pushed the add-operator-version branch from d7780ec to f123faa Compare January 24, 2022 05:54

vinamra28 reviewed Jan 24, 2022

View reviewed changes

tekton-robot assigned vinamra28 Jan 24, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022

tekton-robot merged commit 100b2dc into tektoncd:main Jan 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds operator verison in output of `tkn version` command #1486

Adds operator verison in output of `tkn version` command #1486

PuneetPunamiya commented Jan 21, 2022 •

edited

Loading

tekton-robot commented Jan 21, 2022

tekton-robot commented Jan 21, 2022

vinamra28 left a comment

vinamra28 Jan 21, 2022

tekton-robot commented Jan 24, 2022

tekton-robot commented Jan 24, 2022

vinamra28 left a comment

Adds operator verison in output of tkn version command #1486

Adds operator verison in output of tkn version command #1486

Conversation

PuneetPunamiya commented Jan 21, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jan 21, 2022

tekton-robot commented Jan 21, 2022

vinamra28 left a comment

Choose a reason for hiding this comment

vinamra28 Jan 21, 2022

Choose a reason for hiding this comment

tekton-robot commented Jan 24, 2022

tekton-robot commented Jan 24, 2022

vinamra28 left a comment

Choose a reason for hiding this comment

Adds operator verison in output of `tkn version` command #1486

Adds operator verison in output of `tkn version` command #1486

PuneetPunamiya commented Jan 21, 2022 •

edited

Loading