Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in doc #1434

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Fix link in doc #1434

merged 1 commit into from
Aug 10, 2021

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Aug 10, 2021

This will fix link in docs which is making to
fail CI

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Fix link in doc

This will fix link in docs which is making to
fail CI
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 10, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2021
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@pradeepitm12
Copy link
Contributor

/test pull-tekton-cli-integration-tests


@tekton-robot tekton-robot merged commit 3f3f776 into tektoncd:main Aug 10, 2021
piyush-garg added a commit that referenced this pull request Oct 6, 2021
#1419 | [praveen4g0] Get default sa from configmap defaultconfigs | 2021/07/14-16:15
#1420 | [Pradeep Kumar] Update tkn version to 0.20.0 | 2021/07/21-12:37
#1428 | [Piyush Garg] Fix e2e test failing | 2021/07/23-06:37
#1427 | [Zhu Sheng Li] Remove golden files generated for testing version | 2021/07/23-07:23
#1424 | [Pradeep Kumar] fix rpm build | 2021/07/23-07:37
#1429 | [kim-fitness] Update README.md | 2021/08/06-13:30
#1326 | [Sunghoon Kang] Support `output` option for pipeline/task `start` command | 2021/08/09-09:03
#1430 | [Zhu Sheng Li] Authenticate to registries with Podman's config | 2021/08/10-15:05
#1434 | [Piyush Garg] Fix link in doc | 2021/08/10-18:48
#1378 | [Daniel Helfand] add choco package to tkn repo | 2021/08/10-19:14
null | [Piyush Garg] Bump tekton/pipeline to v0.27.1 | 2021/08/17-13:16
null | [Zhu Sheng Li] Add --keep-since flag to taskrun delete | 2021/08/31-06:35
null | [Zhu Sheng Li] Add value check for since option | 2021/08/31-06:35
null | [vinamra28] Delete runs using resource filter and keep-since | 2021/09/21-09:33
null | [vinamra28] Return error when --resource,--all and --keep-* | 2021/09/21-09:33
null | [Yulia Gaponenko] Bump Hub dependency with latest updates | 2021/09/23-11:26
null | [Piyush Garg] Bump to tektoncd/triggers v0.16.0 | 2021/09/24-07:34
null | [Piyush Garg] Move triggertemplate to use v1beta1 | 2021/09/24-07:34
null | [Piyush Garg] Fix the compilation error in other test pkg | 2021/09/24-07:34
null | [Vincent Demeester] Update some dependencies and remove some replace | 2021/09/28-17:14
null | [Piyush Garg] Update triggerbinding cmd to v1beta1 | 2021/09/29-08:05
null | [Piyush Garg] Update clustertriggerbinding to v1beta1 | 2021/09/29-15:53
null | [Piyush Garg] Fix hardcoded resource version in desc | 2021/09/29-16:17
null | [Piyush Garg] Remove duplicate in triggerbinding | 2021/09/29-16:17
null | [Piyush Garg] Cleanup missed during v1beta1 work | 2021/09/30-05:54
null | [Pradeep Kumar] Adds ignore-running flag to pr,tr delete cmd | 2021/09/30-08:18
null | [Piyush Garg] Update eventlistener list and delete cmd | 2021/09/30-15:56
null | [vinamra28] Update EventListener describe command | 2021/10/01-10:08
null | [vinamra28] Update EventListener logs command | 2021/10/01-10:08
null | [Piyush Garg] Cleanup in builder and pkg for triggers cmd | 2021/10/04-07:49
null | [Piyush Garg] Remove invalid docs files | 2021/10/04-07:49
null | [vinamra28] Add create command for tkn clustertask | 2021/10/04-11:03
null | [vinamra28] Add create command for tkn task | 2021/10/04-11:03
null | [Piyush Garg] Add e2e test for triggers v1beta1 | 2021/10/05-12:52
null | [Piyush Garg] Fix terminal not available after logs in retries pipeline | 2021/10/06-06:41

Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants