Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI installation instructions for deb-based distros #1410

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix CLI installation instructions for deb-based distros #1410

merged 1 commit into from
Jul 5, 2021

Conversation

tpiperatgod
Copy link
Contributor

Changes

I have reported this issue in the website repo: issue#281

Use dpkg instead of rpm to install the .deb package, and before that you need to use curl -LO to fetch the package.

The changes here follow the PR#244.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Signed-off-by: laminar fangtian@kubesphere.io

@tpiperatgod
Fix CLI installation instructions for deb-based distros
d00b0e1 
Use `dpkg` instead of `rpm` to install the `.deb` package, and before that you need to use `curl -LO` to fetch the package.

The changes here follow the [PR244](tektoncd/website#244).

Signed-off-by: laminar <fangtian@kubesphere.io>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 3, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 3, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot
Copy link
Contributor

Hi @tpiperatgod. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2021
@vinamra28
Copy link
Member

/ok-to-test
/lgtm
@tpiperatgod can you please sign the SLA as well?

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2021
@tpiperatgod
Copy link
Contributor Author

/ok-to-test
/lgtm
@tpiperatgod can you please sign the SLA as well?

Okey, I have signed the CLA. You mean this, right?

@vinamra28
Copy link
Member

/retest

vdemeester
vdemeester approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
Thanks @tpiperatgod

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow
Thanks @tpiperatgod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@tekton-robot tekton-robot merged commit ec655e1 into tektoncd:main Jul 5, 2021
pradeepitm12 added a commit that referenced this pull request Jul 14, 2021
@pradeepitm12
New version v0.20.0
d21ad61 
#1409 | [Pradeep Kumar] update readme cli version to v0.19.1 | 2021/06/30-15:54
#1410 | [laminar] Fix CLI installation instructions for deb-based distros | 2021/07/05-10:15
#1393 | [vinamra28] Get tekton components version from configmap | 2021/07/07-09:09
#1411 | [vinamra28] Bump pipelines v0.25.0, triggers 0.14.2 and hub | 2021/07/07-12:05
#1415 | [Vincent Demeester] Force cancel when using tkn pipelinerun cancel 👼 | 2021/07/09-09:48
#1408 | [Anshul Verma] resloves issue/1395 | 2021/07/09-10:12
#1385 | [Nikhil Thomas] Fix TaskRun order in `tkn pr logs` | 2021/07/13-06:13

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit to pradeepitm12/cli that referenced this pull request Jul 15, 2021
@pradeepitm12
New version v0.20.0
e5610f9 
tektoncd#1409 | [Pradeep Kumar] update readme cli version to v0.19.1 | 2021/06/30-15:54
tektoncd#1410 | [laminar] Fix CLI installation instructions for deb-based distros | 2021/07/05-10:15
tektoncd#1393 | [vinamra28] Get tekton components version from configmap | 2021/07/07-09:09
tektoncd#1411 | [vinamra28] Bump pipelines v0.25.0, triggers 0.14.2 and hub | 2021/07/07-12:05
tektoncd#1415 | [Vincent Demeester] Force cancel when using tkn pipelinerun cancel 👼 | 2021/07/09-09:48
tektoncd#1408 | [Anshul Verma] resloves issue/1395 | 2021/07/09-10:12
tektoncd#1385 | [Nikhil Thomas] Fix TaskRun order in `tkn pr logs` | 2021/07/13-06:13

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpiperatgod @tekton-robot @vinamra28 @vdemeester