Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipelinerun delete by label #1402

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add pipelinerun delete by label #1402

merged 1 commit into from
Jun 29, 2021

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jun 23, 2021 •
edited
Loading

Add the ability to delete all pipelinerun that belong to a label.

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add the ability to delete all pipelinerun that belong to a label.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 23, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 23, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/delete.go 94.5% 94.6% 0.1

@chmouel chmouel force-pushed the add-delete-by-label branch from 4d4645c to a08ed5d Compare June 23, 2021 14:05
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/delete.go 94.5% 94.6% 0.1

vdemeester
vdemeester reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one question of the name of the flag. label vs by-label vs --selector (like -l, --selector='': Selector (label query) to filter on, supports '=', '==', and '!='.(e.g. -l key1=value1,key2=value2) ?

@chmouel
Copy link
Member Author

chmouel commented Jun 23, 2021 •
edited
Loading

@vdemeester we have already tkn pipelinerun list (and others i think) that uses the --label flag,

it seems i am the one who introduced that "--label" so wherever there is a consensus i will be happy to alias the old flags and rename this.

(my vote is neutral)

@chmouel
Copy link
Member Author

chmouel commented Jun 23, 2021

/retest

1 similar comment
@vdemeester
Copy link
Member

/retest

@chmouel
Add pipelinerun delete by label
8f7b8a5 
Add the ability to delete all pipelinerun that belong to a label.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel force-pushed the add-delete-by-label branch from a08ed5d to 8f7b8a5 Compare June 25, 2021 06:55
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/delete.go 94.5% 94.6% 0.1

@chmouel
Copy link
Member Author

chmouel commented Jun 25, 2021

/retest

@vdemeester
Copy link
Member

/cc @piyush-garg @pradeepitm12 @nikhil-thomas

@tekton-robot tekton-robot requested a review from piyush-garg June 25, 2021 10:02
@tekton-robot
Copy link
Contributor

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: nikhil-thomas.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @piyush-garg @pradeepitm12 @nikhil-thomas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradeepitm12
Copy link
Contributor

Should we consider to club --keep-since/--keep with --label?
This will make advance auto-prune in the operator much eaiser.
cc: @vdemeester

@chmouel
Copy link
Member Author

chmouel commented Jun 25, 2021

@pradeepitm12 It should work together, or are you speaking in the operator implementation?

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
pradeepitm12
pradeepitm12 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pradeepitm12,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinamra28
Copy link
Member

vinamra28 commented Jun 29, 2021 •
edited
Loading

/lgtm
probably we can have this for taskrun as well

@tekton-robot tekton-robot merged commit d111b31 into tektoncd:main Jun 29, 2021
@chmouel chmouel deleted the add-delete-by-label branch June 29, 2021 11:42
pradeepitm12 added a commit that referenced this pull request Jun 29, 2021
@pradeepitm12
New version v0.19.1
67dbda9 
#1391 | [Piyush Garg] Update readme for latest version | 2021/06/09-07:23
#1390 | [06kellyjac] Fix version command outputting empty | 2021/06/10-08:49
#1392 | [Chmouel Boudjnah] Add --since flag to pipelinerun delete | 2021/06/14-07:30
#1396 | [hasanrashid] Fix broken links in DEVELOPMENT.MD | 2021/06/18-23:20
#1400 | [Chmouel Boudjnah] Fix typo with my name | 2021/06/23-08:53
#1401 | [Christie Wilson] Add link to tkn bundle to main readme 🔗 | 2021/06/23-09:18
#1403 | [Chmouel Boudjnah] Update README about coloring being disabled | 2021/06/24-13:41
#1405 | [Pradeep Kumar] fix default --prefix=false with p/t/ct start | 2021/06/28-11:00
#1402 | [Chmouel Boudjnah] Add pipelinerun delete by label | 2021/06/29-12:09

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@sthaha sthaha Awaiting requested review from sthaha

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@pradeepitm12 pradeepitm12

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chmouel @tekton-robot @vdemeester @pradeepitm12 @vinamra28