Add link to tkn bundle to main readme 🔗 #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always look at this section in the README when im casually trying to figure out if the CLI supports something - this time it was in the context of the implicit params TEP, i wanted to see what validation the cli will do of any bundles it creates. When I didn't see the link I thought "oh no maybe it wasn't added yet" but it was! So I'm adding the link :D
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
|
/retest |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pradeepitm12
added a commit
that referenced
this pull request
Jun 29, 2021
#1391 | [Piyush Garg] Update readme for latest version | 2021/06/09-07:23 #1390 | [06kellyjac] Fix version command outputting empty | 2021/06/10-08:49 #1392 | [Chmouel Boudjnah] Add --since flag to pipelinerun delete | 2021/06/14-07:30 #1396 | [hasanrashid] Fix broken links in DEVELOPMENT.MD | 2021/06/18-23:20 #1400 | [Chmouel Boudjnah] Fix typo with my name | 2021/06/23-08:53 #1401 | [Christie Wilson] Add link to tkn bundle to main readme 🔗 | 2021/06/23-09:18 #1403 | [Chmouel Boudjnah] Update README about coloring being disabled | 2021/06/24-13:41 #1405 | [Pradeep Kumar] fix default --prefix=false with p/t/ct start | 2021/06/28-11:00 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 29, 2021
#1391 | [Piyush Garg] Update readme for latest version | 2021/06/09-07:23 #1390 | [06kellyjac] Fix version command outputting empty | 2021/06/10-08:49 #1392 | [Chmouel Boudjnah] Add --since flag to pipelinerun delete | 2021/06/14-07:30 #1396 | [hasanrashid] Fix broken links in DEVELOPMENT.MD | 2021/06/18-23:20 #1400 | [Chmouel Boudjnah] Fix typo with my name | 2021/06/23-08:53 #1401 | [Christie Wilson] Add link to tkn bundle to main readme 🔗 | 2021/06/23-09:18 #1403 | [Chmouel Boudjnah] Update README about coloring being disabled | 2021/06/24-13:41 #1405 | [Pradeep Kumar] fix default --prefix=false with p/t/ct start | 2021/06/28-11:00 #1402 | [Chmouel Boudjnah] Add pipelinerun delete by label | 2021/06/29-12:09 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I always look at this section in the README when im casually trying to
figure out if the CLI supports something - this time it was in the
context of the implicit params TEP, i wanted to see what validation the
cli will do of any bundles it creates. When I didn't see the link I
thought "oh no maybe it wasn't added yet" but it was! So I'm adding the
link :D
p.s. I was THIS CLOSE to leaving an annoying comment on the initial PR and then i was like: in the time that will take me I could just change it 🤦♀️
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes