Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo with my name #1400

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix typo with my name #1400

merged 1 commit into from
Jun 23, 2021

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jun 22, 2021

Pretty sure it doesn't warrant a minor release for this fix,

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@chmouel
Copy link
Member Author

chmouel commented Jun 22, 2021

/retest

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@tekton-robot tekton-robot merged commit 844d00a into tektoncd:main Jun 23, 2021
@chmouel chmouel deleted the chmousel branch June 27, 2021 05:21
pradeepitm12 added a commit that referenced this pull request Jun 29, 2021
#1391 | [Piyush Garg] Update readme for latest version | 2021/06/09-07:23
#1390 | [06kellyjac] Fix version command outputting empty | 2021/06/10-08:49
#1392 | [Chmouel Boudjnah] Add --since flag to pipelinerun delete | 2021/06/14-07:30
#1396 | [hasanrashid] Fix broken links in DEVELOPMENT.MD | 2021/06/18-23:20
#1400 | [Chmouel Boudjnah] Fix typo with my name | 2021/06/23-08:53
#1401 | [Christie Wilson] Add link to tkn bundle to main readme 🔗 | 2021/06/23-09:18
#1403 | [Chmouel Boudjnah] Update README about coloring being disabled | 2021/06/24-13:41
#1405 | [Pradeep Kumar] fix default --prefix=false with p/t/ct start | 2021/06/28-11:00

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Jun 29, 2021
#1391 | [Piyush Garg] Update readme for latest version | 2021/06/09-07:23
#1390 | [06kellyjac] Fix version command outputting empty | 2021/06/10-08:49
#1392 | [Chmouel Boudjnah] Add --since flag to pipelinerun delete | 2021/06/14-07:30
#1396 | [hasanrashid] Fix broken links in DEVELOPMENT.MD | 2021/06/18-23:20
#1400 | [Chmouel Boudjnah] Fix typo with my name | 2021/06/23-08:53
#1401 | [Christie Wilson] Add link to tkn bundle to main readme 🔗 | 2021/06/23-09:18
#1403 | [Chmouel Boudjnah] Update README about coloring being disabled | 2021/06/24-13:41
#1405 | [Pradeep Kumar] fix default --prefix=false with p/t/ct start | 2021/06/28-11:00
#1402 | [Chmouel Boudjnah] Add pipelinerun delete by label | 2021/06/29-12:09

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants