Add choco package to tkn repo #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
|
/test pull-tekton-cli-unit-tests |
|
/cc @tektoncd/cli-maintainers |
|
/cc @tektoncd/cli-collaborators I noticed a review was requested for me on this b/c I'm in cli-maintainers - so i went to remove myself from that b/c i probably shouldn't be reviewing CLI stuff XD - but then i thought, maybe what we actually wanted here was to request a review from cli-collaborators |
| $ErrorActionPreference = 'Stop'; | ||
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $packageName = 'tektoncd-cli' | ||
| $url64 = 'https://github.com/tektoncd/cli/releases/download/v0.18.0/tkn_0.18.0_Windows_x86_64.zip' |
There was a problem hiding this comment.
Maybe we would like to update the version here.
There was a problem hiding this comment.
Its a placeholder, you can use it for any version from what i understood
|
Can someone help to test/verify this? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
piyush-garg
added a commit
that referenced
this pull request
Oct 6, 2021
#1419 | [praveen4g0] Get default sa from configmap defaultconfigs | 2021/07/14-16:15 #1420 | [Pradeep Kumar] Update tkn version to 0.20.0 | 2021/07/21-12:37 #1428 | [Piyush Garg] Fix e2e test failing | 2021/07/23-06:37 #1427 | [Zhu Sheng Li] Remove golden files generated for testing version | 2021/07/23-07:23 #1424 | [Pradeep Kumar] fix rpm build | 2021/07/23-07:37 #1429 | [kim-fitness] Update README.md | 2021/08/06-13:30 #1326 | [Sunghoon Kang] Support `output` option for pipeline/task `start` command | 2021/08/09-09:03 #1430 | [Zhu Sheng Li] Authenticate to registries with Podman's config | 2021/08/10-15:05 #1434 | [Piyush Garg] Fix link in doc | 2021/08/10-18:48 #1378 | [Daniel Helfand] add choco package to tkn repo | 2021/08/10-19:14 null | [Piyush Garg] Bump tekton/pipeline to v0.27.1 | 2021/08/17-13:16 null | [Zhu Sheng Li] Add --keep-since flag to taskrun delete | 2021/08/31-06:35 null | [Zhu Sheng Li] Add value check for since option | 2021/08/31-06:35 null | [vinamra28] Delete runs using resource filter and keep-since | 2021/09/21-09:33 null | [vinamra28] Return error when --resource,--all and --keep-* | 2021/09/21-09:33 null | [Yulia Gaponenko] Bump Hub dependency with latest updates | 2021/09/23-11:26 null | [Piyush Garg] Bump to tektoncd/triggers v0.16.0 | 2021/09/24-07:34 null | [Piyush Garg] Move triggertemplate to use v1beta1 | 2021/09/24-07:34 null | [Piyush Garg] Fix the compilation error in other test pkg | 2021/09/24-07:34 null | [Vincent Demeester] Update some dependencies and remove some replace | 2021/09/28-17:14 null | [Piyush Garg] Update triggerbinding cmd to v1beta1 | 2021/09/29-08:05 null | [Piyush Garg] Update clustertriggerbinding to v1beta1 | 2021/09/29-15:53 null | [Piyush Garg] Fix hardcoded resource version in desc | 2021/09/29-16:17 null | [Piyush Garg] Remove duplicate in triggerbinding | 2021/09/29-16:17 null | [Piyush Garg] Cleanup missed during v1beta1 work | 2021/09/30-05:54 null | [Pradeep Kumar] Adds ignore-running flag to pr,tr delete cmd | 2021/09/30-08:18 null | [Piyush Garg] Update eventlistener list and delete cmd | 2021/09/30-15:56 null | [vinamra28] Update EventListener describe command | 2021/10/01-10:08 null | [vinamra28] Update EventListener logs command | 2021/10/01-10:08 null | [Piyush Garg] Cleanup in builder and pkg for triggers cmd | 2021/10/04-07:49 null | [Piyush Garg] Remove invalid docs files | 2021/10/04-07:49 null | [vinamra28] Add create command for tkn clustertask | 2021/10/04-11:03 null | [vinamra28] Add create command for tkn task | 2021/10/04-11:03 null | [Piyush Garg] Add e2e test for triggers v1beta1 | 2021/10/05-12:52 null | [Piyush Garg] Fix terminal not available after logs in retries pipeline | 2021/10/06-06:41 Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #652
Changes
Added the choco package to tkn repo to help improve visibility of it. Open to any suggestions on formatting package, etc.
Submitter Checklist
make checkmake generatedRelease Notes