Updates Tests from Tests Builders to Structs #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This patch migrates unit tests for `tkn triggertemplate` from test builders to structs. Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
- This patch migrates unit tests for `tkn triggerbinding` from test builders to structs Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
chmouel
reviewed
May 10, 2021
| @@ -22,16 +22,29 @@ import ( | |||
| "github.com/tektoncd/cli/pkg/test" | |||
| "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1" | |||
| triggertest "github.com/tektoncd/triggers/test" | |||
| tb "github.com/tektoncd/triggers/test/builder" | |||
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
There was a problem hiding this comment.
I think metav1 is used in the code,
There was a problem hiding this comment.
I'll change it to metav1 👍🏻
- This patch migrates unit tests for `tkn clustertriggerbinding` from test builders to structs. Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
- This patch migrates unit tests for `tkn eventlistener` from test builders to structs. Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
test-builders
branch
from
6ef8572 to
8d1bea9
Compare
|
/lgtm |
piyush-garg
added a commit
that referenced
this pull request
Jun 8, 2021
#1361 | [Pradeep Kumar] update cli version to v0.18.0 in readme | 2021/04/27-17:00 #1367 | [PuneetPunamiya] Updates TriggerTemplate Tests from Test Builders to Structs | 2021/05/10-11:28 #1367 | [PuneetPunamiya] Updates TriggerBinding Tests from Test Builders to Structs | 2021/05/10-11:28 #1367 | [PuneetPunamiya] Updates ClusterTriggerBinding Tests from Test Builders to Structs | 2021/05/10-11:28 #1367 | [PuneetPunamiya] Updates Eventlistener Tests from Test Builders to Structs | 2021/05/10-11:28 #1364 | [SM43] Fixes tkn task start to ask for params interactively if not passed | 2021/05/12-06:53 #1366 | [Chmouel Boudjnah] Lookup plugins in current path | 2021/05/12-12:59 #1374 | [vinamra28] Bump plumbing dependencies to fix CI | 2021/05/21-08:18 #1375 | [SM43] Fixes e2e test for ClusterTask | 2021/05/24-05:41 #1369 | [SM43] Bump Hub dependency with latest updates | 2021/05/25-16:30 null | [Piyush Garg] Bump tektoncd/pipeline to v0.24.1 | 2021/06/01-14:47 null | [Anshul Verma] Fixes Issue #1067 Added --component option to just output the version of the components like client|pipeline|triggers | 2021/06/01-15:28 null | [Anshul Verma] Fixes 1000 Interative pipeline/task start fail when `-f` option is used and a `param` in the definition does not have the `type` defined. This fix gives a validation error if any `param` does not have a type defined. | 2021/06/02-10:34 null | [SM43] Fixes pipeline start to ask for params interactively if not passed | 2021/06/02-12:14 null | [SM43] Fixes clusterTask start to ask for params interactively if not passed | 2021/06/02-13:02 null | [vinamra28] Add support for optional workspaces in tkn start | 2021/06/02-13:29 null | [Piyush Garg] Bump to tektoncd/triggers v0.14.1 | 2021/06/02-14:59 null | [Piyush Garg] Fix rpm spec file | 2021/06/02-15:38 null | [vinamra28] Common Description for workspace flag in start command | 2021/06/02-19:37 null | [Chmouel Boudjnah] Add a flag to not print the taskname/step prefix when showing logs | 2021/06/03-08:59 null | [Chmouel Boudjnah] Replace maze.io/x/duration with its redirect | 2021/06/08-09:37 Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This patch updates Tests from Test Builders to Structs for
Signed-off-by: Puneet Punamiya ppunamiy@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes