Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dots when numbering in languages other than chinese #11

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

tyhdefu
Copy link
Contributor

@tyhdefu tyhdefu commented Mar 6, 2022

I have made it so that dots . are used instead of enumeration commas if the language is not chinese. I believe this is the most common punctuation for this, so i made it for all languages except chinese.
I had to use .\00a0 to put a space between the enumeration and the title on the sidebar. Since the dot does not have built-in space, unlike , it sits right next to it otherwise.

@tyhdefu tyhdefu marked this pull request as draft March 6, 2022 21:13
@tyhdefu
Copy link
Contributor Author

tyhdefu commented Mar 6, 2022

This still needs changes for other heading levels

@tyhdefu
Copy link
Contributor Author

tyhdefu commented Mar 6, 2022

Now everything should work for sub-headings. I have tried my best to do the correct thing for chinese characters, but please tell me if I made a mistake, or if you want me to change anything.

This should also fix the inconsistency here:
image

@tyhdefu tyhdefu marked this pull request as ready for review March 6, 2022 22:09
@Neutree Neutree merged commit 2ed9a20 into teedoc:main Mar 7, 2022
@Neutree
Copy link
Member

Neutree commented Mar 7, 2022

thanks, but have some wrong changes for Chinese, I will fix it right away~

e.g. only H2 need Chinese number
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants