Fix an issue where the IMAP stream isn't reloaded after it's lost. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If $this->imapStream is lost, it will return 0. These conditionals evalute 0 as a set variable, therefore they don't reload the stream even though they should.
1 similar comment
tedivm
added a commit
that referenced
this pull request
Mar 31, 2015
Fix an issue where the IMAP stream isn't reloaded after it's lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
$this->imapStreamis lost, it will return0. These conditionals evaluated0as a set variable, therefore they didn't reload the stream even though they should have. Using empty() instead ensures that$this->imapStreamis set and not0.