Add more RSpec aliases #1624
Add more RSpec aliases #1624
Conversation
| @@ -21,9 +23,12 @@ def self.included(base) | |||
| alias :background :before | |||
| alias :scenario :it | |||
| alias :xscenario :xit | |||
| alias :fscenario :fit | |||
There was a problem hiding this comment.
does RSpec 2.X has fit or fdescribe aliases?
http://www.relishapp.com/rspec/rspec-core/v/2-14/docs/configuration/alias-example-to
|
How does the test output look like: |
|
Only Ruby 1.9.3 build (the second one? there are two builds on 1.9.3) fails. https://travis-ci.org/jnicklas/capybara/jobs/96986194 Any assistance? |
|
As a guess RSpec 2.2 doesn't support exclude_pattern= -- don't break out these tests into a separate task and just test for the metadata in the test rather than that true == true. |
| @in_filtered_hook = true | ||
| end | ||
|
|
||
| ffeature "if ffeature alises focused tag then" do |
|
@twalpole I have merged these tasks and refactored focus tag specs |
| alias :given :let | ||
| alias :given! :let! | ||
| alias :feature :describe | ||
| alias :xfeature :xdescribe |
There was a problem hiding this comment.
The base version of RSpec we currently claim support for (2.2) doesn't support xdescribe -- don't add any of these changes for RSpec 2 - capybara will no longer support it in the next major release anyway
|
rbx-2 uses rspec-core 3.4.1 and fails after removing rspec 2 aliases. need to investigate |
| @in_filtered_hook = true | ||
| end | ||
|
|
||
| if RSpec::Core::Version::STRING.to_f >= 3.0 || RUBY_ENGINE == 'rbx' |
There was a problem hiding this comment.
@twalpole I don't know if it's good idea to put if statement for rbx. I'm unfamiliar with it at all. Do you think it's acceptable?
There was a problem hiding this comment.
I have no idea why 'rbx' would cause a failure here, and really don't want to skip testing on it without understanding exactly why it's failing
|
Ok looks like the tests pass, please squash this down to one commit |
|
Should I force push to |
|
Just squash and force push, and in the future please create a feature branch in your repo for changes, rather than doing it in master |
New tags are ffeature (tag focus: true) / xfeature (pending)
|
@twalpole thanks you assistance and patience! :) |
Add ffeature and xfeature RSpec aliases
|
Thanks a lot! |
Introducing
xfeature,ffeatureandfscenario