Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for and/or compounding of rspec matchers with tests #1328

Merged
merged 1 commit into from
Jun 12, 2014

Conversation

twalpole
Copy link
Member

No description provided.

@twalpole
Copy link
Member Author

@jnicklas The real issue with this is that HaveSelector needs to catch the Capybara::ExpectationNotMet exception and then ends up raising an RSpec::Expectations::ExpectationNotMetError exception. This may necessitate waiting for a major version update if there was a guarantee of HaveSelector raising Capybara::ExpecationNotMet on failure. I don't see it documented (or specifically tested) anywhere. What would your thoughts on it be?

@abotalov
Copy link
Collaborator

I think it should be done in major version.

@abotalov
Copy link
Collaborator

It wasn't documented but it's a quiet well known (and reliable) fact that those methods raise Capybara::ExpectationNotMet error - http://stackoverflow.com/search?q=%5Bcapybara%5D+ExpectationNotMet

@abotalov
Copy link
Collaborator

Also as this is backwards incompatible change please take a look on #1246 as it refactors this code too (I know that I should rebase it, maybe fix something, include Composable, etc.)

@twalpole
Copy link
Member Author

@abotalov all of the entries I looked at in that search were people trying to figure out why their matcher was failing, none of them seemed to be people rescuing that specific exception. I'm not convinced this needs to go into a major release.

twalpole added a commit that referenced this pull request Jun 12, 2014
support for and/or compounding of rspec matchers with tests
@twalpole twalpole merged commit 8d1fea1 into master Jun 12, 2014
@dblooman
Copy link

Is there a release cycle for capybara, wondering when this will make it into the gem?

@twalpole
Copy link
Member Author

@DaveBlooman There is no fixed release cycle. I'm aiming for the next release in 1-2 weeks

@dblooman
Copy link

Thanks for update and the PR.

@twalpole twalpole deleted the compound_matchers branch August 26, 2015 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants