Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linux): Use c_ulong for ffi calls instead of u64 #106

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix(linux): Use c_ulong for ffi calls instead of u64 #106

merged 1 commit into from
Sep 11, 2024

Conversation

FabianLars
Copy link
Member

fixes #105 - note that i didn't test this in an actual app but cargo check --target ... stopped complained with these changes. It's also similar to my Wry change a while ago that seemingly was fine.

@github-actions GitHub Actions
Copy link
Contributor

Package Changes Through 7d584d5

There are 1 changes which include global-hotkey with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
global-hotkey 0.6.1 0.6.2

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir merged commit 2c7397b into dev Sep 11, 2024
8 checks passed
@amrbashir amrbashir deleted the fox/32bit branch September 11, 2024 13:42
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
@greenhat616
Copy link

greenhat616 commented Sep 11, 2024 •
edited
Loading

Thank you. It works fine via cross test --all-features --target i686-unknown-linux-gnu.

# cross test --all-features --target i686-unknown-linux-gnu
[+] Building 1.6s (7/7) FINISHED                                                                                                                                                 docker:default
 => [internal] load build definition from Dockerfile.i686-unknown-linux-gnu-custom                                                                                                         0.0s
 => => transferring dockerfile: 250B                                                                                                                                                       0.0s
 => [internal] load metadata for ghcr.io/libnyanpasu/builder-debian-trixie-i686:latest                                                                                                     1.5s
 => [auth] libnyanpasu/builder-debian-trixie-i686:pull token for ghcr.io                                                                                                                   0.0s
 => [internal] load .dockerignore                                                                                                                                                          0.0s
 => => transferring context: 2B                                                                                                                                                            0.0s
 => [1/2] FROM ghcr.io/libnyanpasu/builder-debian-trixie-i686:latest@sha256:da1d6feff36122b177dee4663b3c8d7b4dde3711edea135b93a171c7e24eb439                                               0.0s
 => CACHED [2/2] RUN eval "apt-get update && apt-get install --assume-yes libgtk-3-dev:$CROSS_DEB_ARCH libxdo-dev:$CROSS_DEB_ARCH"                                                         0.0s
 => exporting to image                                                                                                                                                                     0.0s
 => => exporting layers                                                                                                                                                                    0.0s
 => => writing image sha256:565b6ac49c7f84d38324d8f3ac23c2af24a62bd92bb3f4f407429a55369d47a1                                                                                               0.0s
 => => naming to docker.io/library/cross-custom-global-hotkey:i686-unknown-linux-gnu-87f70-pre-build                                                                                       0.0s
   Compiling global-hotkey v0.6.2 (/project)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 5.18s
     Running unittests src/lib.rs (/target/i686-unknown-linux-gnu/debug/deps/global_hotkey-6fef474a1f3ccdb2)

running 2 tests
test hotkey::test_equality ... ok
test hotkey::test_parse_hotkey ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failed on all x32 target(including i686, armv7)
3 participants
@FabianLars @greenhat616 @amrbashir