Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #126, use pydantic w/ dxfeed, don't raise for orders, add more futures exp utils #127

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Graeme22
Copy link
Contributor

@Graeme22 Graeme22 commented Feb 9, 2024

Description

dxfeed events moved to pydantic validation + coercion, now Decimal instead of float.
Illegal orders don't raise an exception, but rather log an error, because sometimes we want to see BP.
Futures exp utils added: indices & oil

Related issue(s)

Fixes #126

Pre-merge checklist

  • Passing tests LOCALLY
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

@Graeme22 Graeme22 merged commit 8ed0693 into master Feb 9, 2024
1 check failed
@Graeme22 Graeme22 deleted the dxfeed-pydantic branch February 9, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested Option Chain not working on indices
1 participant