Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mult android arch #424

Merged
merged 8 commits into from
Dec 16, 2015
Merged

Mult android arch #424

merged 8 commits into from
Dec 16, 2015

Conversation

tallytalwar
Copy link
Member

Deploy tangram library for multiple architectures for android.

@tallytalwar tallytalwar force-pushed the mult-android-arch branch 4 times, most recently from 1f70cc8 to ecc7374 Compare December 9, 2015 15:13
@tallytalwar
Copy link
Member Author

This is mostly done. However not able to figure out __atomic_*_8 linking issues for mips and armeabi architectures. Both of these are old and very rarely used architectures.

@tallytalwar tallytalwar changed the title [WIP] Mult android arch Mult android arch Dec 12, 2015
@tallytalwar
Copy link
Member Author

Marking this for review.
Following works:

  • armeabi-v7a
  • arm64-v8a
  • x86
  • x86_64
  • mips64

Still not able to figure out how to get armeabi and mips architecture working. Based on https://code.google.com/p/android/issues/detail?id=182094, providing -latomic should have done the trick, but does not seem to resolve the issue. I might not be looking at some wrong place in android toolchain.

I am actually fine with not having support for these 2 architecture, if we can not find a way to fix the builds for these, since there are not many devices based on these architectures.

@tallytalwar
Copy link
Member Author

@hjanetzek Since you already on this, can you review this and merge?

Thanks

@@ -3,7 +3,16 @@
set -e
set -o pipefail

if [ "${PLATFORM}" = "android" ] && [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "master" ]; then
if [ "${PLATFORM}" = "android" ] && [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "mult-android-arch" ]; then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tallytalwar can we rename the branch to android-deploy? Since we will have to push to this branch to deploy the android libs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it there for testing, but I guess for now we want to build all (or selected architectures) on every master build. So before merging this, we can revert this change back to master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. ok

@matteblair
Copy link
Member

Glad all the architectures are working now! Now that I'm looking at all of them in the CI builds, we may want to pare down the number of architectures that we build - 25 minutes is just too long to wait for a CI build.

I think a reasonable set of architectures to support for now would be:

  • ARMv7
  • x86
  • ARM64

If someone requests a MIPS build, then we can think about those ;)

@hjanetzek
Copy link
Member

So.. ready to merge once you decided which platforms to build :)

@tallytalwar
Copy link
Member Author

I think we will wait on this at least until tomorrow to discuss in the mobile meeting for what architectures to build and what should be the appropriate strategy to have multiple architecture deployment, considering it costs us ~4mins per architecture on travis.

@tallytalwar
Copy link
Member Author

So based on the discussion in the mobile meeting today, I have modified the travis deployment script to do builds for armeabi, armeabi-v7a (default build), arm64-v8a and x86.

Deployment will only happen for the master branch builds.

Will merge once travis goes green.

Trimming android architectures to armeabi, armeabi-v7a, x86, arm64-v8a.
Deployment will happen on only master branch
tallytalwar added a commit that referenced this pull request Dec 16, 2015
@tallytalwar tallytalwar merged commit 72bb0c1 into master Dec 16, 2015
@tallytalwar tallytalwar deleted the mult-android-arch branch December 16, 2015 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants