-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mult android arch #424
Mult android arch #424
Conversation
1f70cc8
to
ecc7374
Compare
This is mostly done. However not able to figure out |
ecc7374
to
ec01f76
Compare
Marking this for review.
Still not able to figure out how to get I am actually fine with not having support for these 2 architecture, if we can not find a way to fix the builds for these, since there are not many devices based on these architectures. |
- Supports: x86, x86_64, armeabi, armeabi-v7a (default), arm64_v8a, mips, mips64 NOTE/TODO: Figure out linking error for `armeabi` and `mips` architectures.
ec01f76
to
e0d3252
Compare
@hjanetzek Since you already on this, can you review this and merge? Thanks |
@@ -3,7 +3,16 @@ | |||
set -e | |||
set -o pipefail | |||
|
|||
if [ "${PLATFORM}" = "android" ] && [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "master" ]; then | |||
if [ "${PLATFORM}" = "android" ] && [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "mult-android-arch" ]; then | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tallytalwar can we rename the branch to android-deploy? Since we will have to push to this branch to deploy the android libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it there for testing, but I guess for now we want to build all (or selected architectures) on every master
build. So before merging this, we can revert this change back to master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. ok
Glad all the architectures are working now! Now that I'm looking at all of them in the CI builds, we may want to pare down the number of architectures that we build - 25 minutes is just too long to wait for a CI build. I think a reasonable set of architectures to support for now would be:
If someone requests a MIPS build, then we can think about those ;) |
So.. ready to merge once you decided which platforms to build :) |
I think we will wait on this at least until tomorrow to discuss in the mobile meeting for what architectures to build and what should be the appropriate strategy to have multiple architecture deployment, considering it costs us ~4mins per architecture on travis. |
So based on the discussion in the mobile meeting today, I have modified the travis deployment script to do builds for Deployment will only happen for the Will merge once travis goes green. |
Trimming android architectures to armeabi, armeabi-v7a, x86, arm64-v8a. Deployment will happen on only master branch
affe0d4
to
afc4032
Compare
Deploy tangram library for multiple architectures for android.