-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add continuous scrolling speed adjustment #1649
Add continuous scrolling speed adjustment #1649
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I added the ability to set the scrolling speed when starting continuous scrolling. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I found a bug that should be resolved before merge. |
Actually, the "issue" seems to happen without my pull request. Is it intended for some reason for using the continuous scrolling action twice in the same direction to stop the scrolling completely? |
Yes that is on purpose. For people using a foot switch, noise or other to toggle the scrolling on and off. |
@knausj85 Will test this. If someone else has time before that please go ahead. |
I initially thought this was a bug too; these commands used to be compatible with repeaters and such. I guess I missed that memo! If needed, we can explore how to make these more friendly for hotkeys / pedals in a separate issue I tested this a bit and it's a great improvement. I've a few minor suggestions before we merge. |
for more information, see https://pre-commit.ci
This reverts commit 3ed0a38.
for more information, see https://pre-commit.ci
There is a separate few bugs with this logic though that we might as well fix while we're here:
I took a quick swing at fixing that. |
I identified an issue where if the scrolling speed becomes less than one but non-zero the result is no scrolling. Should I address that by rounding up? (This can happen when trying to set the scrolling speed to a small number) |
It looks like float values for the scrolling speed get truncated, so changing the scrolling speed from some values to certain other values through voice commands has no effect. I am not sure if we should try to address that to make increasing speed value always increase the actual scrolling speed, but the issue is worth noting. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks.
Add the ability to adjust continuous scrolling speed while scrolling by dictating a number_small. The speed becomes the speed setting multiplied by the dictated number divided by ten. The acceleration gets reset every time the speed gets changed. The scrolling speed reverts to the default after the current scroll is finished.
closes #1648