Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursorless support for jetbrains #1628

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

asoee
Copy link

@asoee asoee commented Dec 1, 2024

No description provided.

Copy link
Collaborator

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires your new extension, right? Can we detect if they have that or not? I guess it will error out either way but it might be nice if we can show a more precise error. (I know a lot of people were confused by the error the existing code shows that you don't have the old plugin because it's very esoteric)

@jaresty
Copy link
Contributor

jaresty commented Dec 10, 2024

Would it be possible to merge this change behind a tag? In other words only enable it if the tag is enabled? It would make it easier for folks to try out the change...just a thought.

@jaresty
Copy link
Contributor

jaresty commented Dec 10, 2024

For what it's worth, you can enable this without modifying the community repo: jaresty/mac-dotfiles@dff0250

@asoee
Copy link
Author

asoee commented Jan 13, 2025

@phillco: this PR is backwards compatible with the old plugin, except that it ALSO enables cursorless commands.
in honesty, there is 3 changes in this PR:

  • Fix a bug in the error handling for send_idea_command, where the err handling itself caused a new exception, that was hiding the original error.
  • Add the tag to enable cursorless for jetbrains.
  • Add the extra stuff to the command server, to make it work with jetbrains

the tag part could of course be changed to do like for vscode here:
https://github.com/cursorless-dev/cursorless-talon/blob/main/src/apps/cursorless_vscode.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants