Make it so you can only speak a valid layout

There are two kinds of valid layouts:
- layouts that are pairs
- layout that are trios

While there maybe layout arrangements that are greater than twos and threes, it's difficult to say the number of applications required to trigger those layouts.

Refactor layouts to operate on windows in preparation for window layouts.

Enable using the trio and pair snap layouts to rotate layouts

- now if you say 'snap clock' twice in a row it will rotate the focused window

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Start counting for layouts at the active window

Extract _top_n_windows helper function in preparation for adding ordinals for focus

Provide convenience function to pick a specific window to focus

- If you say 'snap first split' it will split without changing the order
- If you say 'snap third clock' will swap the third window with the first, so you can repeat to swap them back

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Make the error message a little more intuitive

Provide away to snap a window by index

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Provide a shortcut to focus an application and snap to a layout at the same time

Slightly adjust grammar based on feedback

Optimized for reducing dfa rules

- This requires a little bit more manual finesse than the previous version but it does allow you to snap specific applications and leave others alone. If you say, 'snap clock code', for example, it won't affect anything but the code windows. You can say, 'snap clock code all' to effect windows after code by appending all other windows after the code windows. If you say, 'snap clock' alone it will continue to rotate the windows as before.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Handle error resizing window

- There might be a better approach, but this will at least try to snap all windows specified.  (ran into an unresizable window in zoom)

Gracefully handle snap errors

- If a snap error happens, it will continue trying to snap
- Struggled to maintain rotate behavior, but it seems to be working presently

Implement gap support

Refactor some duplicate code

Cleanup extra print statements

Prevent an error if you tried to pop a zero number of snapped windows

Respond opal request feedback by making the snapping move to the right instead of the left

Now it only rotates when focus was done by snap layout first

- Next need to reset this variable when focus is done by other means

Make it so snap layout only rotates when it was the last thing used to snap

Optimized to fix race condition

- Calling focus has a delay so, we have to wait until the function is done before we can be sure that we can start listening for events again

Responding to pull request feedback

- I don't want to make a required argument because using the layout with no arguments is useful. What do you think about changing this name to lay?

Make window layout into a data class responding to pull request feedback

Responding to pull request feedback

- Removed debug print statement
- Renamed to reflect that all windows is not really the correct name: it's really all candidate windows will be considered for layout

Exposed public method for snapping windows to position by name

Clarify that the snap failure is normal and provide additional details

Remove usage of time delays to ensure snapping does not have a race

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Breakout layout to another file

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Refactor window layout code to clarify

Handle window focusing errors

First pass at pull request feedback from today

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Removed some debug printing and an exception that I can't make more specific yet

Update core/windows_and_tabs/window_snap.py

Co-authored-by: Phil Cohen <phillip@phillip.io>

Fixed typo

Removed debug logs

Need to pass window from calling function

The active window is not always in the list passed in

Index filtering should be based on the index in all windows not based on the index in windows passed in

Cleanup imports

Rescue another exception type that I ran into

Respond to pull request feedback:

- There was a concern that some people might want to rename these position names
- This allows for renaming them in one location without breaking the other functionality

Extract window snap positions as a talon list

Make GapWindow into a proper class

Handle the deep copy earlier

Ensure that snap layout finishes by resetting the layout in progress

Add types to pick_split_arrangement and cleanup snap_layout a bit

Skip filtering of application windows

- sometimes filters windows that should not be filter

Remove filter nonviable windows

- It doesn't work as effectively as just skipping when the snap fails

Removed debug logging

Revert "Remove filter nonviable windows"

This reverts commit 463d68a.

Remove stray debug print statement

- Fix repeater
- Fix rotating multiple times - store an offset counter and increase it each time
- various other code tweaks for clarity

Use idiomatic types for optionals

cleanup

window_layout: documentation

window_layout: fix gaps, repeating with an independent command

Reset the rotation count when the layout windows change

Respond to pull request feedback

- It is cleaner to add to the existing condition rather than resetting the rotation count as a one-off condition

Respond full request feedback

- According to aegis, copy_windows was not doing anything. I'm not sure I understand this feedback so feel free to revert if you disagree.

Respond to pull request feedback

- Rather than specifying the layout name and number and having it picked by the number of windows specified, it is more intuitive to use a different name for each layout.

 Respond to pull request feedback

 - We were asked to make it so that the split position names could be renamed easily