Switch audio assets to Opus #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SFX are TODO. SDL2_Mixer can not decode opus chunks (because OF COURSE it can't); we probably should at least resample them to 48k.
2.0.5 doesn't have the SDL_AudioStream API, and is ancient anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the distribution size by about 20 megabytes, which is particularly nice for the web version. The music has been encoded from the original lossless source, so there's no generational loss. In fact, an increase in fidelity is likely. Unfortunately there is no lossless source for the sound effects, so they had to be re-encoded from the Vorbis files. I did not notice any regressions in quality, though.
Dependencies changes:
SDL2_mixerversion requirement raised to2.0.4to support streaming of Opus music.opusfileto load Opus SFX chunks (SDL2_mixeris too dumb to do that apparently).SDL2version requirement raised to2.0.6, because theSDL_AudioStreamAPI is used to resample the Opus SFX if needed.It is possible to avoid bumping the
SDL2_mixerversion requirement by implementing Opus streaming manually viaMix_HookMusic, but that's a pain in the ass and not worth the effort in my opinion.