tstime: add Since method #8622
Merged
tstime: add Since method #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairew
force-pushed
the
clairew/tstime-since
branch
2 times, most recently
from
1e3cd0d to
43acf6f
Compare
sailorfrag
approved these changes
Jul 14, 2023
Updates #8463 Signed-off-by: Claire Wang <claire@tailscale.com>
clairew
force-pushed
the
clairew/tstime-since
branch
from
43acf6f to
28a72c5
Compare
bradfitz
reviewed
Jul 14, 2023
| @@ -303,6 +303,11 @@ func (c *Clock) AfterFunc(d time.Duration, f func()) tstime.TimerController { | |||
| return t | |||
| } | |||
|
|
|||
| // Since subtracts specified duration from Now(). | |||
There was a problem hiding this comment.
there is no duration specified here.
How about we copy the docs from the standard library, which says:
Since returns the time elapsed since t. It is shorthand for time.Now().Sub(t).
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
Updates tailscale#8463 Signed-off-by: Claire Wang <claire@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #8463