-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4: Expand glob imports #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
v0.4-imports
branch
3 times, most recently
from
December 26, 2021 05:37
160fb5b
to
525cd91
Compare
```text warning: warn(unaligned_references) incompatible with previous forbid --> tests/lint.rs:20:5 | 4 | #![forbid(future_incompatible, rust_2018_compatibility)] | ------------------- `forbid` level set here ... 20 | unaligned_references, | ^^^^^^^^^^^^^^^^^^^^ overruled by previous forbid ```
taiki-e
force-pushed
the
v0.4-imports
branch
from
December 26, 2021 05:53
525cd91
to
ebf2c14
Compare
taiki-e
force-pushed
the
v0.4-imports
branch
from
December 26, 2021 05:59
ebf2c14
to
1cb267f
Compare
bors r+ |
By the way, as of 2021/12/26, 0.4.28 is still being downloaded around 10,000 times a day (on weekdays). |
Build succeeded: |
taiki-e
added a commit
that referenced
this pull request
Dec 27, 2021
- 0.4.28 and older releases have been yanked because they failed to compile with syn 1.0.84 and later. See #335 for more. - Mention the minimal version of syn increased in 1.0.9.
rillian
added a commit
to brave/brave-core
that referenced
this pull request
Jan 19, 2022
This is a transitive dependency through futures-retry. The 0.4.28 version was yanked for compile errors with syn 1.0.84 and later. See taiki-e/pin-project#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of ab1f198.
0.4.28 and older versions are failed to compile with syn 1.0.84 and later.
See ddcd880 for v1.0.