Getting started download buttons #82
Conversation
|
Deploy preview for tachiyomi ready! Built with commit 827a064 |
|
It's ready to be checked now @arkon |
|
Not sure what changed, but last time I looked it was good, now it looks like this: |
|
EDIT: I presume it tried to look for |
| @@ -7,7 +7,7 @@ lang: en-US | |||
|
|
|||
| ## Installation | |||
|
|
|||
| [](https://github.com/inorichi/tachiyomi/releases/latest) [](http://www.somsubhra.com/github-release-stats/?username=inorichi&repository=tachiyomi) | |||
| <DownloadButtons/> | |||
There was a problem hiding this comment.
Looking at this, it seems like we have an opportunity to actually make it more reusable for the home page as well. Thoughts?
There was a problem hiding this comment.
The entire home page is written as a single <template> section, not sure how exactly to go about it adding a Vue element in that, not sure how to go about that.
Apparently you can add Vue component straight into a <template> section. Inserting it quickly without any edits yielded this:
| </ul> | ||
| </template> | ||
|
|
||
| <style scoped lang="stylus"> |
There was a problem hiding this comment.
Why Stylus? That being said, I originally suggested using Sass when the Vuepress stuff was implemented, but maybe we can just use Stylus if there's no real benefit to that...
There was a problem hiding this comment.
Both has great benefits, their use cases are very similiar. I can stick to SASS (SCSS) if that's the standard we want, they're almost interchangeable at certain levels anyways, the one I used here could be switched to <style scoped lang="scss"> and it was still fully functional.
| const { data } = await axios.get(RELEASE_URL); | ||
| // Maybe eventually some release has more than the apk in assets. | ||
| const apkAsset = data.assets.find(a => a.name.includes('.apk')); | ||
| // Set the values. | ||
| this.$data.tagName = data.tag_name; | ||
| this.$data.browserDownloadUrl = apkAsset.browser_download_url; |
There was a problem hiding this comment.
Taken straight from Home.vue to generate the correct download link.
There was a problem hiding this comment.
That's usually a cue that the code should refactored to be reusable. :)
That's okay though, it can be refactored later.
There was a problem hiding this comment.
Yeah, based on your comments on earlier PRs I shouldn't do that in the same PR but split them up instead.
| const { data } = await axios.get(RELEASE_URL); | ||
| // Maybe eventually some release has more than the apk in assets. | ||
| const apkAsset = data.assets.find(a => a.name.includes('.apk')); | ||
| // Set the values. | ||
| this.$data.tagName = data.tag_name; | ||
| this.$data.browserDownloadUrl = apkAsset.browser_download_url; |
There was a problem hiding this comment.
That's usually a cue that the code should refactored to be reusable. :)
That's okay though, it can be refactored later.
Changed the getting started buttons to look much more "professional".
I wanted to change more on the page but that will be a seperate PR.
This is aimed toward issue #62 by @j2ghz.