This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add visualisation images for navigation layout #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: curche <72807749+curche@users.noreply.github.com>
|
Deploy preview for tachiyomi ready! Built with commit 1584902 |
Soitora
suggested changes
Mar 2, 2021
There was a problem hiding this comment.
Sorry about the late review, didn't notice this until @Seishirou101 brought it to my attention.
I would reword the Carousel items description, move away from the "Is default..." to like "This is the default..."
Soitora
approved these changes
Mar 2, 2021
arkon
pushed a commit
that referenced
this pull request
Mar 2, 2021
* Add visualisation images for navigation layout Co-Authored-By: curche <72807749+curche@users.noreply.github.com> * Add small description for Navigation layout * Reword Co-authored-by: curche <72807749+curche@users.noreply.github.com> 2e84f61
arkon
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add visualisation images for navigation layout Co-Authored-By: curche <72807749+curche@users.noreply.github.com> * Add small description for Navigation layout * Reword Co-authored-by: curche <72807749+curche@users.noreply.github.com>
arkon
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add visualisation images for navigation layout Co-Authored-By: curche <72807749+curche@users.noreply.github.com> * Add small description for Navigation layout * Reword Co-authored-by: curche <72807749+curche@users.noreply.github.com> 587e652
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #503
This also moves invert tapping due to it been moved in the app
Co-Authored-By: curche 72807749+curche@users.noreply.github.com