This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Create global constants file #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for tachiyomi ready! Built with commit 5d52a3a |
arkon
reviewed
Jul 29, 2020
Change printWidth from 80, recommended project widths were at 100/120 so I choose 120. Also while I'm doing it, tweak the EndOfLine setting to prevent VS Code from going ham on LF/CRLF sets.
And other import whitespace near it
arkon
approved these changes
Jul 29, 2020
Closed
arkon
pushed a commit
that referenced
this pull request
Jul 29, 2020
* Create global constants file * Update constants import for all files * Tweak project style guides Change printWidth from 80, recommended project widths were at 100/120 so I choose 120. Also while I'm doing it, tweak the EndOfLine setting to prevent VS Code from going ham on LF/CRLF sets. * Remove the ESLint ignore lines in PR And other import whitespace near it * SNAKE_CASE constants instead of camelCase 6a660e9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having all files use their own
constof the re-used assets such as URLs for download, put them in a globalconstants.jsfile and import to each file when needed.