Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook share error since today #80

Closed
LDSign opened this issue Aug 19, 2016 · 6 comments
Closed

Facebook share error since today #80

LDSign opened this issue Aug 19, 2016 · 6 comments
Labels

Comments

@LDSign
Copy link

LDSign commented Aug 19, 2016

Hi

The facebook share or facebook itself throws an error since this morning:

"OAuthException: (#12) fql is deprecated for versions v2.1 and higher"

Could you have a look at it?

Thanks,
Frank

@tabalinas tabalinas added the bug label Aug 19, 2016
@mustafaonurcelik
Copy link

mustafaonurcelik commented Aug 20, 2016

OK. here is a quick solution of mine to get this work before @tabalinas fixes the issue.

replace those lines in jssocials.js.. (line : 448 to 458)

facebook: {
            label: "Like",
            logo: "fa fa-facebook",
            shareUrl: "https://facebook.com/sharer/sharer.php?u={url}",
            countUrl: function() {
                return "http://graph.facebook.com/?id=" + this.url;
            },
            getCount: function(data) {
                return data.share.share_count;
            }
        },

@LDSign
Copy link
Author

LDSign commented Aug 20, 2016

Hi

Thanks for your answer. But this is getting me

Uncaught TypeError: Cannot read property 'share_count' of undefined

:(

Frank

@tabalinas
Copy link
Owner

tabalinas commented Aug 20, 2016

@mustafaonurcelik, thank you for the solution.

@LDSign, seems to work fine for me. Are you sure you have shares for the url you are testing?
I think, this check should be enough:

getCount: function(data) {
   return data.share && data.share.share_count || 0;
}

@mustafaonurcelik
Copy link

unfortunately this solution is also dead as of today :(

@tabalinas
Copy link
Owner

Are you sure? It's still working for the demo page http://js-socials.com/demos/

Why do you think it's dead?

@mustafaonurcelik
Copy link

I was getting error #403 but now it's OK, i don't know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants