-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Workshop Publication Requirements #4424
Merged
JavidPack
merged 19 commits into
tModLoader:1.4.4
from
TechnicalitiesDevelopment:feature/improvePublicationChecksForWorkshop
Oct 23, 2024
Merged
Increase Workshop Publication Requirements #4424
JavidPack
merged 19 commits into
tModLoader:1.4.4
from
TechnicalitiesDevelopment:feature/improvePublicationChecksForWorkshop
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…escription before publishing to workshop. See tModLoader#3843
…escription before publishing to workshop. See tModLoader#3643
…/github.com/TechnicalitiesDevelopment/tModLoader into feature/improvePublicationChecksForWorkshop
…escription before publishing to workshop. See tModLoader#3643
…/github.com/TechnicalitiesDevelopment/tModLoader into feature/improvePublicationChecksForWorkshop
Mirsario
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will edit the description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
It increases the checks made before publishing on the workshop to make it impossible to publish mods without changing their icon or description. It also checks for a description with fewer than 50 letters/digits to publish and scales up the icon.png file when publishing. If the workshop icon is from another folder it will be copied over to the mod sources folder as well.
Why should this be part of tModLoader?
See #3643
Are there alternative designs?
Heavy moderation of the workshop
Porting Notes
If they have a mod with the default description or icon then they have to change that prior to updating.