Fix incorrect fishing line offset with vanilla bobbers on modded rods. #4060
Conversation
|
Looking go so far. We will want ExampleFishingRod and ExampleBobber fixed in this PR as well. Also, we want existing mod usage to continue working, so make sure the existing modprojectile hook is still being called, but mark it as [Obsolete("", error: true)] so that it must be fixed for the mod to be rebuilt. You'll want to move ProjectileLoader.ModifyFishingLine to ItemLoader as well. (You'll be calling an Obsolete ProjectileLoader.ModifyFishingLine from ItemLoader.ModifyFishingLine to preserve existing functionality. ) Once that is done, I'll work on the tModPorter steps, I think we can do it with a HookRemoved entry. If you are adventurous and want to try doing the tModPorter and corresponding tests, you can, but it's a bit finnicky and I can do it when I merge this PR. |
|
As a side note, since the line color is now depending on the rod, I suppose it will be more difficult to make different line colors on rods that fire multiple bobbers. At least I could not come up with any way, so I made the ExampleRod use a single color for now. |
|
Looks good. I made some more changes to add back in the original behavior. Thanks a lot for spearheading this. |
What is the bug?
[#3906]
Since the fishing line offset of modded rods was bound to bobbers, vanilla bobber accessories that replaced the original projectile of modded rods were causing incorrect offset.
Vanilla rods:
Modded rods:
Fixed modded rods:
How did you fix the bug?
Move ModifyFishingLine() hook to the ModItem class. This, alas, has no backward compatibility.
Are there alternatives to your fix?
Since vanilla bobber projectiles completely replace modded ones, there probably aren't any.
Additionally, ExampleFishingRod and ExampleBobber should also be updated.