-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Complete Builder Toggle API #3943
Merged
JavidPack
merged 11 commits into
tModLoader:1.4.4
from
Cyrillya:1.4.4-complete-builder-toggle
Feb 15, 2024
Merged
A Complete Builder Toggle API #3943
JavidPack
merged 11 commits into
tModLoader:1.4.4
from
Cyrillya:1.4.4-complete-builder-toggle
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirsario
requested changes
Feb 14, 2024
I can take care of the feedback items mentioned when I review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
A Complete Builder Toggle API
Closes #3857
Why should this be part of tModLoader?
The current Builder Toggle API in tModLoader is incomplete and missing features. This pr allows mod builder toggles to:
Some issues to point out
DisplayColorTexture
hook for customizing the color. But the new custom drawing ability fully covers that use. Should we remove this hook to avoid confusion, or keep it for backwards compatibility?GlobalBuilderToggle
? I don't have a proper way to correctly handle states with multiple mods for now without changing the structure.Are there alternative designs?
Make builder toggle state into a seperate class like
BuilderToggleState
.BuilderToggleState
is registered toBuilderToggle
. Make hooks such as left-click/right-click functionality and custom drawing intoBuilderToggleState
This can be a proper way to handle states added to one vanilla builder toggle by multiple mods. But requires an overhaul of the current system
ExampleMod updates