Onerror Callback Support for Errors Fetching External Import Map #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging onerror-callback-support into master will impact 3 files in 2 groups. browser (2/2)
node (1/1)
extras (0/8)No impact on files in extras group. |
guybedford
reviewed
Apr 28, 2021
src/features/import-maps.js
Outdated
| try { | ||
| script.onerror(); | ||
| } catch(callbackErr) { | ||
| callbackErr.message = 'Error during onerror script for systemjs-importmap: ' + script.src + '\n' + callbackErr.message; |
There was a problem hiding this comment.
This error should be obtainable from the stack anyway, so let's remove this try-catch wrapper rather. Or did you specifically find the stack didn't have the information needed?
There was a problem hiding this comment.
The stack has the required info, I will remove the try-catch, thanks for the quick review 👍
guybedford
requested changes
Apr 28, 2021
guybedford
approved these changes
Apr 28, 2021
10 tasks
1 task
This was referenced Jun 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These changes are for being able to execute custom error handling logic when fetching external import maps. On event of this error, if defined, the script in the
onerrorattribute will be executed.This is addressing this issue.