Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement integrity in import map #2229

Merged
merged 5 commits into from
Aug 10, 2020
Merged

Implement integrity in import map #2229

merged 5 commits into from
Aug 10, 2020

Conversation

guybedford
Copy link
Member

This implements a new "integrity" attribute in the import map, which is consulted when creating scripts for injection to use as the primary integrity mechanism.

In this way a full integrity content security policy can be applied to apps built on top of SystemJS.

Like depcache this is non-standard right now, but I have put together a rough standard outline in the import maps extensions repo at https://github.com/guybedford/import-maps-extensions#integrity.

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

core

File by file impact

File Transform Diff master integrity Event
dist/s.js none -355 21,553 21,198 changed
gzip -64 6,117 6,053
brotli -63 5,278 5,215
dist/s.min.js none -130 6,559 6,429 changed
gzip -46 2,638 2,592
brotli -42 2,359 2,317
dist/system-node.cjs none +2,400 200,985 203,385 changed
gzip +777 51,345 52,122
brotli +534 43,451 43,985
dist/system.js none -355 31,999 31,644 changed
gzip -67 8,631 8,564
brotli -73 7,479 7,406
dist/system.min.js none -130 10,584 10,454 changed
gzip -45 4,084 4,039
brotli -35 3,651 3,616
extras

File by file impact

Pull request have no impact on extras files.

Generated by github pull request filesize impact

src/features/import-maps.js Show resolved Hide resolved
src/features/resolve.js Show resolved Hide resolved
Copy link
Collaborator

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations. Looks good to me.

@guybedford guybedford merged commit 5547865 into master Aug 10, 2020
@guybedford guybedford deleted the integrity branch August 10, 2020 18:56
@guybedford
Copy link
Member Author

guybedford commented Aug 10, 2020

Released in 6.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants