Fixup and simplify auto import cases #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreFile by file impact
extrasFile by file impactPull request have no impact on |
|
Released in 6.4.2. |
1 task
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues pointed out in #2223 (comment), where the timeout is triggering after the ready state has changed thus cancelling an in-progress auto import.
It turns out the timeout mechanism is actually unnecessary as the process of simply checking the registration to clear it in the dynamic case is all that is needed.
The other mechanism to clear the auto import registry entirely has been removed as it's mostly a GC optimization for some impractical edge cases, whereas most proper usage would never hit those. So it also removes some bytes.