Safari cross origin fix #2222
Merged
Safari cross origin fix #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreFile by file impact
extrasFile by file impactPull request have no impact on |
|
That's a clever fix, thanks a lot. It should work for me from the looks of it, I'll test it out tomorrow at work. |
joeldenning
reviewed
Jul 30, 2020
guybedford
force-pushed
the
cross-origin-fix
branch
from
41ae51b to
710b7e2
Compare
1 task
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2220 by restricting setting the cross origin attribute only on actual cross origin requests.
/cc @LarsDenBakker let me know if this works for you.