Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proposal(template) ability to use es6+ in src code #2079

Closed
wants to merge 1 commit into from

Conversation

smff
Copy link

@smff smff commented Nov 29, 2019

No description provided.

@smff smff changed the title Added proposal ability to use es6 in src code Added proposal ability to use es6+ in src code Nov 29, 2019
@smff smff changed the title Added proposal ability to use es6+ in src code Added proposal(template) ability to use es6+ in src code Nov 29, 2019
@kouts
Copy link
Contributor

kouts commented Nov 29, 2019

I think that Babel or other transpiling options are left intentionally out, because of the additional weight they add to the resulting code.

@smff
Copy link
Author

smff commented Nov 29, 2019

@kouts perhaps, but my solution is just a template that gives and opportunity to tune whatever you want, in whichever way you want it to be. Also it allows for use of es6+
If you are talking about bundle weight it is easy to fix with any minimizer but it's not related with this PR

@joeldenning
Copy link
Collaborator

Like @kouts said, adding a compiler such as babel introduces some bloat to the code and removes ability to fine tune exactly what the output is like.

I have talked to Guy Bedford about this in the past, and he is very much willing to make sacrifices to the DX in order to deliver a smaller bundle to users. Over the last several months, his comments on my PRs have consistently emphasized importance of saving bytes in the output bundles.

I like babel and use it for many of my projects, but I am closing this PR because it is not something that the systemjs project itself will use.

@smff
Copy link
Author

smff commented Nov 29, 2019

@joeldenning ok)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants