Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old browsers not supporting forEach in querySelectorAll result #2033

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Fix old browsers not supporting forEach in querySelectorAll result #2033

merged 1 commit into from
Sep 21, 2019

Conversation

HeavenVolkoff
Copy link
Contributor

Replace document.querySelectorAll(...).forEach with Array.prototype.forEach.call(document.querySelectorAll, ...) due to old browsers (ex: IE 11) not supporting entries|forEach|keys|values methods in NodeList.

@guybedford
Copy link
Member

Thanks for the PR!

@guybedford guybedford merged commit 8c2a05d into systemjs:master Sep 21, 2019
@jonbjk jonbjk mentioned this pull request Sep 22, 2019
Closed
@HeavenVolkoff HeavenVolkoff deleted the hotfix-forEach branch September 22, 2019 21:04
@renovate renovate bot mentioned this pull request May 29, 2021
Open
1 task
This was referenced Jun 6, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeavenVolkoff @guybedford